Don't print type & kind if redundant

Author: msabramo

request.go

@@ -33,10 +33,15 @@ var (
 
 // ErrUnsupportedPtrType is returned when the Struct field was a pointer but
 // the JSON value was of a different type
-func ErrUnsupportedPtrType(rf reflect.Value, f reflect.Type, structField reflect.StructField) error {
+func ErrUnsupportedPtrType(rf reflect.Value, t reflect.Type, structField reflect.StructField) error {
+	typeName := t.Elem().Name()
+	kind := t.Elem().Kind()
+	if kind.String() != "" && kind.String() != typeName {
+		typeName = fmt.Sprintf("%s (%s)", typeName, kind.String())
+	}
 	return fmt.Errorf(
-		"[jsonapi unmarshalNode]: Can't unmarshal %+v (%s) to struct field `%s`, which is a pointer to `%s` (%s), which is not a supported type",
-		rf, rf.Type().Name(), structField.Name, f.Elem().Name(), f.Elem().Kind(),
+		"[jsonapi]: Can't unmarshal %+v (%s) to struct field `%s`, which is a pointer to `%s`, which is not a supported type",
+		rf, rf.Type().Name(), structField.Name, typeName,
 	)
 }
 

request_test.go

@@ -126,7 +126,7 @@ func TestUnmarshalToStructWithPointerAttr_BadType(t *testing.T) {
 	in := map[string]interface{}{
 		"name": true, // This is the wrong type.
 	}
-	expectedErrorMessage := "[jsonapi unmarshalNode]: Can't unmarshal true (bool) to struct field `Name`, which is a pointer to `string` (string), which is not a supported type"
+	expectedErrorMessage := "[jsonapi]: Can't unmarshal true (bool) to struct field `Name`, which is a pointer to `string`, which is not a supported type"
 
 	err := UnmarshalPayload(sampleWithPointerPayload(in), out)