add tests

Author: Dinwy

lib/protocol/packets/RowDataPacket.js

@@ -1,7 +1,6 @@
-var Types                        = require('../constants/types');
-var Charsets                     = require('../constants/charsets');
-var Field                        = require('./Field');
-var IEEE_754_BINARY_64_PRECISION = Math.pow(2, 53);
+var Types     = require('../constants/types');
+var Charsets  = require('../constants/charsets');
+var Field     = require('./Field');
 
 module.exports = RowDataPacket;
 function RowDataPacket() {
@@ -100,8 +99,7 @@ function typeCast(field, parser, timeZone, supportBigNumbers, bigNumberStrings,
       numberString = parser.parseLengthCodedString();
       return (numberString === null || (field.zeroFill && numberString[0] == "0"))
         ? numberString
-        : ((supportBigNumbers && (bigNumberStrings || (Number(numberString) > IEEE_754_BINARY_64_PRECISION)))
-          ? numberString
+          : ((supportBigNumbers && (bigNumberStrings || (Number(numberString) > Number.MAX_SAFE_INTEGER || Number(numberString) < Number.MIN_SAFE_INTEGER)))          ? numberString
           : Number(numberString));
     case Types.BIT:
       return parser.parseLengthCodedBuffer();

test/common.js

@@ -149,7 +149,8 @@ function mergeTestConfig(config) {
     host     : process.env.MYSQL_HOST,
     port     : process.env.MYSQL_PORT,
     user     : process.env.MYSQL_USER,
-    password : process.env.MYSQL_PASSWORD
+    password : process.env.MYSQL_PASSWORD,
+    supportBigNumbers: true,
   }, config);
 
   return config;

test/integration/connection/test-protocol-bigint.js

@@ -0,0 +1,37 @@
+var assert = require('assert');
+var common = require('../../common');
+
+var table = 'bigint_test';
+
+common.getTestConnection(function (err, connection) {
+  assert.ifError(err);
+
+  common.useTestDb(connection);
+
+  connection.query([
+    'CREATE TEMPORARY TABLE ?? (',
+    '`id` int(11) unsigned NOT NULL AUTO_INCREMENT,',
+    '`big` bigint,',
+    'PRIMARY KEY (`id`)',
+    ') ENGINE=InnoDB DEFAULT CHARSET=utf8'
+  ].join('\n'), [table], assert.ifError);
+
+  connection.query('INSERT INTO ?? SET ?', [table, {big: '9223372036854775807'}]);
+  connection.query('INSERT INTO ?? SET ?', [table, {big: '-9223372036854775807'}]);
+  connection.query('INSERT INTO ?? SET ?', [table, {big: '1111111111111111111'}]);
+  connection.query('INSERT INTO ?? SET ?', [table, {big: '-1111111111111111111'}]);
+  connection.query('INSERT INTO ?? SET ?', [table, {big: '9007199254740993'}]);
+  connection.query('INSERT INTO ?? SET ?', [table, {big: '-9007199254740993'}]);
+
+  connection.query('SELECT * FROM ??', [table], function (err, rows) {
+    assert.ifError(err);
+    assert.equal(rows.length, 6);
+    assert.deepStrictEqual(rows[0].big, '9223372036854775807');
+    assert.deepStrictEqual(rows[1].big, '-9223372036854775807');
+    assert.deepStrictEqual(rows[2].big, '1111111111111111111');
+    assert.deepStrictEqual(rows[3].big, '-1111111111111111111');
+    assert.deepStrictEqual(rows[4].big, '9007199254740993');
+    assert.deepStrictEqual(rows[5].big, '-9007199254740993');
+    connection.end(assert.ifError);
+  });
+});

test0.js

@@ -0,0 +1,32 @@
+var mysql      = require('mysql');
+var express = require('express')
+, http = require('http')
+, app = express()
+, server = http.createServer(app);
+
+var db_config = {
+connectionLimit : 10,
+host     : 'localhost',
+user     : 'root',
+password : 'root!',
+database : 'kdtestdb',
+supportBigNumbers: true,
+}
+
+var pool  = mysql.createPool(db_config);
+
+app.get('/*', function (req, res) {
+pool.query('SELECT * FROM test;', function(err, rows, fields) {
+if (err){
+  console.log("error");
+throw err
+} else {
+  console.log(rows);
+res.send(rows);
+};
+});
+});
+
+var listener = app.listen(8080, function() {
+  console.log('Express server listening on port ' + listener.address().port);
+});