fix: typing for commission_asset

DeevsDeevs · DeevsDeevs · commit 3d2579189cdc · 2024-12-31T04:11:34.000+01:00
diff --git a/nautilus_trader/adapters/binance/futures/schemas/user.py b/nautilus_trader/adapters/binance/futures/schemas/user.py
@@ -322,7 +322,7 @@ def handle_order_trade_update(  # noqa: C901 (too complex)
             )
         elif self.x == BinanceExecutionType.TRADE:
             # Determine commission
-            commission_asset: str | float | None = self.N
+            commission_asset: str | None = self.N
             commission_amount: str | float | None = self.n
 
             last_qty = Quantity(float(self.l), size_precision)

Original file line number	Diff line number	Diff line change
`@@ -322,7 +322,7 @@ def handle_order_trade_update( # noqa: C901 (too complex)`
`322`	`322`	`)`
`323`	`323`	`elif self.x == BinanceExecutionType.TRADE:`
`324`	`324`	`# Determine commission`
`325`		`- commission_asset: str \| float \| None = self.N`
	`325`	`+ commission_asset: str \| None = self.N`
`326`	`326`	`commission_amount: str \| float \| None = self.n`
`327`	`327`
`328`	`328`	`last_qty = Quantity(float(self.l), size_precision)`