Prevent usage of a branch with pending migrations

Author: jeremystretch

netbox_branching/models/branches.py

@@ -132,7 +132,7 @@ def is_active(self):
 
     @property
     def ready(self):
-        return self.status == BranchStatusChoices.READY
+        return self.status == BranchStatusChoices.READY and not self.pending_migrations
 
     @property
     def merged(self):

netbox_branching/templates/netbox_branching/buttons/branch_migrate.html

@@ -1,5 +1,6 @@
 {% load i18n %}
-{% if perms.netbox_branching.migrate_branch and branch.ready %}
+
+{% if perms.netbox_branching.migrate_branch and branch.status == 'ready' %}
   <a href="{% url 'plugins:netbox_branching:branch_migrate' pk=branch.pk %}" class="btn btn-primary">
     <i class="mdi mdi-step-forward"></i> {% trans "Migrate" %}
   </a>

netbox_branching/templatetags/branch_buttons.py

@@ -1,5 +1,7 @@
 from django import template
 
+from netbox_branching.choices import BranchStatusChoices
+
 __all__ = (
     'branch_sync_button',
     'branch_merge_button',

netbox_branching/views.py

@@ -341,7 +341,7 @@ def post(self, request, **kwargs):
         action_permitted = getattr(branch, f'can_merge')
         form = self.form(request.POST)
 
-        if not branch.ready:
+        if branch.status != BranchStatusChoices.READY:
             messages.error(request, _("The branch is not ready to be migrated."))
         elif form.is_valid():
             # Enqueue a background job to migrate the Branch