[REF] web_editor, website_blog: convert many2one SnippetOption to OWL

task-3850413

# Conflicts:
#	addons/website_blog/static/src/js/options.js

Author: robinlej

addons/web_editor/static/src/js/editor/snippets.options.js

@@ -9332,25 +9332,30 @@ registerOption("container_width", {
  * Allows to replace a text value with the name of a database record.
  * @todo replace this mechanism with real backend m2o field ?
  */
-legacyRegistry.many2one = SnippetOptionWidget.extend({
-    init() {
-        this._super(...arguments);
-        this.orm = this.bindService("orm");
-    },
-
+export class Many2oneOption extends SnippetOption {
+    constructor() {
+        super(...arguments);
+        this.orm = this.env.services.orm;
+    }
     /**
      * @override
      */
     async willStart() {
+        await super.willStart(...arguments);
         const {oeMany2oneModel, oeMany2oneId} = this.$target[0].dataset;
         this.fields = ['name', 'display_name'];
-        return Promise.all([
-            this._super(...arguments),
+        
+        const [{name: modelName}] = await this.orm.searchRead("ir.model", [['model', '=', oeMany2oneModel]], ['name']);
+        this.renderContext.model = oeMany2oneModel;
+        this.renderContext.fields = JSON.stringify(this.fields);
+        this.renderContext.modelName = modelName;
+
+        return Promise.resolve([
             this.orm.read(oeMany2oneModel, [parseInt(oeMany2oneId)], this.fields).then(([initialRecord]) => {
                 this.initialRecord = initialRecord;
             }),
         ]);
-    },
+    }
 
     //--------------------------------------------------------------------------
     // Options
@@ -9390,7 +9395,7 @@ legacyRegistry.many2one = SnippetOptionWidget.extend({
             this.$prevContents = this.$target.contents();
             this.prevRecordName = record.name;
         }
-    },
+    }
 
     //--------------------------------------------------------------------------
     // Private
@@ -9403,22 +9408,8 @@ legacyRegistry.many2one = SnippetOptionWidget.extend({
         if (methodName === 'changeRecord') {
             return this.$target[0].dataset.oeMany2oneId;
         }
-        return this._super(...arguments);
-    },
-    /**
-     * @override
-     */
-    async _renderCustomXML(uiFragment) {
-        const many2oneWidget = document.createElement('we-many2one');
-        many2oneWidget.dataset.changeRecord = '';
-
-        const model = this.$target[0].dataset.oeMany2oneModel;
-        const [{name: modelName}] = await this.orm.searchRead("ir.model", [['model', '=', model]], ['name']);
-        many2oneWidget.setAttribute('String', modelName);
-        many2oneWidget.dataset.model = model;
-        many2oneWidget.dataset.fields = JSON.stringify(this.fields);
-        uiFragment.appendChild(many2oneWidget);
-    },
+        return super._computeWidgetState(...arguments);
+    }
     /**
      * @private
      */
@@ -9453,8 +9444,15 @@ legacyRegistry.many2one = SnippetOptionWidget.extend({
                     node.textContent = defaultText;
                 }
             }));
-    },
+    }
+}
+registerOption("Many2oneOption", {
+    Class: Many2oneOption,
+    template: "web_editor.many2one",
+    selector: "[data-oe-many2one-model]:not([data-oe-readonly])",
+    noCheck: true,
 });
+
 /**
  * Allows to display a warning message on outdated snippets.
  */

addons/web_editor/static/src/js/editor/snippets.options.xml

@@ -1172,4 +1172,9 @@
     <WeInput selectStyle="''" unit="'px'" cssProperty="'padding'" title.translate="Padding"/>
 </t>
 
+<t t-name="web_editor.many2one">
+    <WeMany2one changeRecord="''" model="renderContext.model" fields="renderContext.fields"
+                title="renderContext.modelName"/>
+</t>
+
 </templates>

addons/web_editor/views/snippets.xml

@@ -390,10 +390,6 @@
 <!-- options (data-selector, data-drop-in, data-drop-near, data-js to link js object ) -->
 <template id="snippet_options">
     <!-- t-field -->
-    <div data-js='many2one'
-         data-selector="[data-oe-many2one-model]:not([data-oe-readonly])"
-         data-no-check="true"/>
-
     <div data-selector=".s_hr"
          data-drop-near="p, h1, h2, h3, blockquote, .s_hr"/>
 

addons/website_blog/static/src/js/options.js

@@ -1,33 +1,32 @@
 /** @odoo-module **/
 
 import { _t } from "@web/core/l10n/translation";
-import options from "@web_editor/js/editor/snippets.options.legacy";
-import { SnippetOption } from "@web_editor/js/editor/snippets.options";
+import { SnippetOption, Many2oneOption } from "@web_editor/js/editor/snippets.options";
 import {
     CoverProperties,
 } from "@website/js/editor/snippets.options";
 import {
     registerWebsiteOption,
 } from "@website/js/editor/snippets.registry";
 import { updateOption } from "@web_editor/js/editor/snippets.registry";
-import "@website/js/editor/snippets.options";
 import { uniqueId } from "@web/core/utils/functions";
 import { patch } from "@web/core/utils/patch";
 
 const NEW_TAG_PREFIX = 'new-blog-tag-';
 
-options.registry.many2one.include({
-
+patch(Many2oneOption.prototype, {
     //--------------------------------------------------------------------------
     // Private
     //--------------------------------------------------------------------------
 
     /**
      * @override
+     * TODO: check why it's there and possibly remove the patch entirely. This
+     * "overrides" a method that does not exist on the parent.
      */
-    _selectRecord: function ($opt) {
+    _selectRecord($opt) {
         var self = this;
-        this._super.apply(this, arguments);
+        super._selectRecord.apply(this, arguments);
         if (this.$target.data('oe-field') === 'author_id') {
             var $nodes = $('[data-oe-model="blog.post"][data-oe-id="' + this.$target.data('oe-id') + '"][data-oe-field="author_avatar"]');
             $nodes.each(function () {