Skip to content

Commit 80084df

Browse files
fix(gofeatureflag): fix etag in tests to be around quotes (#1432)
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
1 parent f4c9e0c commit 80084df

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

providers/go-feature-flag/src/test/java/dev/openfeature/contrib/providers/gofeatureflag/api/GoFeatureFlagApiTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ public void requestShouldHaveReturn200SimpleFlags() {
657657
flags.put("TEST2", flag2);
658658
val want = FlagConfigResponse.builder()
659659
.flags(flags)
660-
.etag("valid-flag-config.json")
660+
.etag("\"valid-flag-config.json\"")
661661
.lastUpdated(new SimpleDateFormat("EEE, dd MMM yyyy HH:mm:ss zzz")
662662
.parse("Wed, 21 Oct 2015 07:28:00 GMT"))
663663
.evaluationContextEnrichment(evaluationContextEnrichment)
@@ -702,7 +702,7 @@ public void requestShouldNotReturnLastModifiedDateIfInvalidHeader() {
702702
flags.put("TEST2", flag2);
703703
val want = FlagConfigResponse.builder()
704704
.flags(flags)
705-
.etag("valid-flag-config.json")
705+
.etag("\"valid-flag-config.json\"")
706706
.lastUpdated(null)
707707
.evaluationContextEnrichment(evaluationContextEnrichment)
708708
.build();

providers/go-feature-flag/src/test/java/dev/openfeature/contrib/providers/gofeatureflag/util/GoffApiMock.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,7 +132,7 @@ public MockResponse handleFlagConfiguration(RecordedRequest request) {
132132
return new MockResponse()
133133
.setResponseCode(200)
134134
.setBody(TestUtils.readMockResponse("flag_config_responses/", configLocation))
135-
.addHeader(Const.HTTP_HEADER_ETAG, "different-etag")
135+
.addHeader(Const.HTTP_HEADER_ETAG, "\"different-etag\"")
136136
.addHeader(Const.HTTP_HEADER_LAST_MODIFIED, "Wed, 21 Oct 2015 05:28:00 GMT");
137137
}
138138
break;
@@ -153,7 +153,7 @@ public MockResponse handleFlagConfiguration(RecordedRequest request) {
153153
return new MockResponse()
154154
.setResponseCode(200)
155155
.setBody(TestUtils.readMockResponse("flag_config_responses/", configLocation))
156-
.addHeader(Const.HTTP_HEADER_ETAG, configLocation)
156+
.addHeader(Const.HTTP_HEADER_ETAG, "\"" + configLocation + "\"")
157157
.addHeader(Const.HTTP_HEADER_LAST_MODIFIED, "Wed, 21 Oct 2015 07:28:00 GMT");
158158
}
159159
switch (etag) {
@@ -171,13 +171,13 @@ public MockResponse handleFlagConfiguration(RecordedRequest request) {
171171
return new MockResponse()
172172
.setResponseCode(200)
173173
.setBody(TestUtils.readMockResponse("flag_config_responses/", configLocation))
174-
.addHeader(Const.HTTP_HEADER_ETAG, configLocation)
174+
.addHeader(Const.HTTP_HEADER_ETAG, "\"" + configLocation + "\"")
175175
.addHeader(Const.HTTP_HEADER_LAST_MODIFIED, "Wed, 21 Oct 2015 07:2 GMT");
176176
default:
177177
return new MockResponse()
178178
.setResponseCode(200)
179179
.setBody(TestUtils.readMockResponse("flag_config_responses/", configLocation))
180-
.addHeader(Const.HTTP_HEADER_ETAG, configLocation)
180+
.addHeader(Const.HTTP_HEADER_ETAG, "\"" + configLocation + "\"")
181181
.addHeader(Const.HTTP_HEADER_LAST_MODIFIED, "Wed, 21 Oct 2015 07:28:00 GMT");
182182
}
183183
}

0 commit comments

Comments
 (0)