From da76cd175411c98a55ac98329e6723e9db147bb7 Mon Sep 17 00:00:00 2001 From: Todd Baert Date: Fri, 7 Mar 2025 11:36:34 -0500 Subject: [PATCH 1/2] chore: adjust noisy log lines Signed-off-by: Todd Baert --- .../contrib/providers/flagd/FlagdProvider.java | 10 +++++----- .../flagd/resolver/process/InProcessResolver.java | 6 +++--- .../flagd/resolver/process/storage/FlagStore.java | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java index f9efbda9c..6633a6c77 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java @@ -193,7 +193,7 @@ EvaluationContext getEnrichedContext() { @SuppressWarnings("checkstyle:fallthrough") private void onProviderEvent(FlagdProviderEvent flagdProviderEvent) { - log.info("FlagdProviderEvent event {} ", flagdProviderEvent.getEvent()); + log.debug("FlagdProviderEvent event {} ", flagdProviderEvent.getEvent()); synchronized (syncResources) { /* * We only use Error and Ready as previous states. @@ -231,7 +231,7 @@ private void onProviderEvent(FlagdProviderEvent flagdProviderEvent) { break; default: - log.info("Unknown event {}", flagdProviderEvent.getEvent()); + log.warn("Unknown event {}", flagdProviderEvent.getEvent()); } } } @@ -245,7 +245,7 @@ private void onConfigurationChanged(FlagdProviderEvent flagdProviderEvent) { private void onReady() { if (syncResources.initialize()) { - log.info("initialized FlagdProvider"); + log.info("Initialized FlagdProvider"); } if (errorTask != null && !errorTask.isCancelled()) { errorTask.cancel(false); @@ -256,7 +256,7 @@ private void onReady() { } private void onError() { - log.info("Connection lost. Emit STALE event..."); + log.debug("Stream error. Emitting STALE event and scheduling ERROR event..."); log.debug("Waiting {}s for connection to become available...", gracePeriod); this.emitProviderStale(ProviderEventDetails.builder() .message("there has been an error") @@ -271,7 +271,7 @@ private void onError() { () -> { if (syncResources.getPreviousEvent() == ProviderEvent.PROVIDER_ERROR) { log.debug( - "Provider did not reconnect successfully within {}s. Emit ERROR event...", + "Provider did not reconnect successfully within {}s. Emitting ERROR event...", gracePeriod); flagResolver.onError(); this.emitProviderError(ProviderEventDetails.builder() diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java index 8d6e1e4b0..032068945 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java @@ -68,18 +68,18 @@ public void init() throws Exception { flagStore.getStateQueue().take(); switch (storageStateChange.getStorageState()) { case OK: - log.info("onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED"); + log.debug("onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED"); onConnectionEvent.accept(new FlagdProviderEvent( ProviderEvent.PROVIDER_CONFIGURATION_CHANGED, storageStateChange.getChangedFlagsKeys(), storageStateChange.getSyncMetadata())); - log.info("post onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED"); + log.debug("post onConnectionEvent.accept ProviderEvent.PROVIDER_CONFIGURATION_CHANGED"); break; case ERROR: onConnectionEvent.accept(new FlagdProviderEvent(ProviderEvent.PROVIDER_ERROR)); break; default: - log.info(String.format( + log.warn(String.format( "Storage emitted unhandled status: %s", storageStateChange.getStorageState())); } } diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/FlagStore.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/FlagStore.java index 32feb49a4..02123a241 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/FlagStore.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/resolver/process/storage/FlagStore.java @@ -143,7 +143,7 @@ private void streamerListener(final QueueSource connector) throws InterruptedExc } break; default: - log.info(String.format("Payload with unknown type: %s", payload.getType())); + log.warn(String.format("Payload with unknown type: %s", payload.getType())); } } From 388d206a55bacdc2f6999080683dc80f24a5e16b Mon Sep 17 00:00:00 2001 From: Todd Baert Date: Mon, 10 Mar 2025 09:11:36 -0400 Subject: [PATCH 2/2] fixup: combine debug lines Signed-off-by: Todd Baert --- .../openfeature/contrib/providers/flagd/FlagdProvider.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java index 6633a6c77..6907f5764 100644 --- a/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java +++ b/providers/flagd/src/main/java/dev/openfeature/contrib/providers/flagd/FlagdProvider.java @@ -256,8 +256,9 @@ private void onReady() { } private void onError() { - log.debug("Stream error. Emitting STALE event and scheduling ERROR event..."); - log.debug("Waiting {}s for connection to become available...", gracePeriod); + log.debug( + "Stream error. Emitting STALE, scheduling ERROR, and waiting {}s for connection to become available.", + gracePeriod); this.emitProviderStale(ProviderEventDetails.builder() .message("there has been an error") .build());