From 59256be29f24073ceed10fb339a10fc38cb2e2c9 Mon Sep 17 00:00:00 2001
From: Simon Schrottner <simon.schrottner@dynatrace.com>
Date: Tue, 11 Jun 2024 09:42:27 +0200
Subject: [PATCH 1/2] feat: avoid star imports via checkstyle

Star imports are seen as a bad practice within java,
as they can lead to a too tight coupling with packages
and introduction of name clashes, hence that we should
avoit them.

closes: #816
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
---
 checkstyle.xml                                            | 8 ++++++--
 .../contrib/providers/envvar/EnvVarProvider.java          | 7 ++++++-
 .../providers/envvar/EnvironmentKeyTransformer.java       | 3 ++-
 .../contrib/providers/jsonlogic/JsonlogicProvider.java    | 7 ++++++-
 4 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/checkstyle.xml b/checkstyle.xml
index eaf475b18..00a22d00c 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -51,7 +51,7 @@
     <module name="TreeWalker">
         <!-- needed for SuppressWarningsFilter -->
         <module name="SuppressWarningsHolder" />
-        
+
         <module name="SuppressWarnings">
             <property name="id" value="checkstyle:suppresswarnings"/>
         </module>
@@ -62,7 +62,11 @@
                         default="checkstyle-xpath-suppressions.xml" />
             <property name="optional" value="true"/>
         </module>
-    
+
+
+        <module name="AvoidStarImport">
+        </module>
+
         <module name="OuterTypeFilename"/>
         <module name="IllegalTokenText">
             <property name="tokens" value="STRING_LITERAL, CHAR_LITERAL"/>
diff --git a/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvVarProvider.java b/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvVarProvider.java
index cd1241423..d421242f9 100644
--- a/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvVarProvider.java
+++ b/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvVarProvider.java
@@ -1,6 +1,11 @@
 package dev.openfeature.contrib.providers.envvar;
 
-import dev.openfeature.sdk.*;
+import dev.openfeature.sdk.EvaluationContext;
+import dev.openfeature.sdk.FeatureProvider;
+import dev.openfeature.sdk.Metadata;
+import dev.openfeature.sdk.ProviderEvaluation;
+import dev.openfeature.sdk.Reason;
+import dev.openfeature.sdk.Value;
 import dev.openfeature.sdk.exceptions.FlagNotFoundError;
 import dev.openfeature.sdk.exceptions.ParseError;
 import dev.openfeature.sdk.exceptions.ValueNotConvertableError;
diff --git a/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvironmentKeyTransformer.java b/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvironmentKeyTransformer.java
index 42a8ef83c..1b68fd6f5 100644
--- a/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvironmentKeyTransformer.java
+++ b/providers/env-var/src/main/java/dev/openfeature/contrib/providers/envvar/EnvironmentKeyTransformer.java
@@ -1,6 +1,7 @@
 package dev.openfeature.contrib.providers.envvar;
 
-import java.util.function.*;
+import java.util.function.Function;
+import java.util.function.UnaryOperator;
 
 import lombok.RequiredArgsConstructor;
 import org.apache.commons.lang3.StringUtils;
diff --git a/providers/jsonlogic-eval-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java b/providers/jsonlogic-eval-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java
index 8617ac691..3a02598d9 100644
--- a/providers/jsonlogic-eval-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java
+++ b/providers/jsonlogic-eval-provider/src/main/java/dev/openfeature/contrib/providers/jsonlogic/JsonlogicProvider.java
@@ -1,6 +1,11 @@
 package dev.openfeature.contrib.providers.jsonlogic;
 
-import dev.openfeature.sdk.*;
+import dev.openfeature.sdk.EvaluationContext;
+import dev.openfeature.sdk.FeatureProvider;
+import dev.openfeature.sdk.Metadata;
+import dev.openfeature.sdk.ProviderEvaluation;
+import dev.openfeature.sdk.Reason;
+import dev.openfeature.sdk.Value;
 import dev.openfeature.sdk.exceptions.ParseError;
 import io.github.jamsesso.jsonlogic.JsonLogic;
 import io.github.jamsesso.jsonlogic.JsonLogicException;

From 44fd49d0a0222446bfe64e3bd4b2b9509bb79418 Mon Sep 17 00:00:00 2001
From: Simon Schrottner <simon.schrottner@dynatrace.com>
Date: Tue, 11 Jun 2024 16:58:33 +0200
Subject: [PATCH 2/2] change formatting

Co-authored-by: madhead <siarhei.krukau@gmail.com>
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
---
 checkstyle.xml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/checkstyle.xml b/checkstyle.xml
index 00a22d00c..2a7a8d05c 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -64,8 +64,7 @@
         </module>
 
 
-        <module name="AvoidStarImport">
-        </module>
+        <module name="AvoidStarImport" />
 
         <module name="OuterTypeFilename"/>
         <module name="IllegalTokenText">