From 039e102fd02148303aaa853e5a4577a2df5a126c Mon Sep 17 00:00:00 2001
From: Ali Rassas <113321173+theflyfoxX@users.noreply.github.com>
Date: Mon, 23 Jun 2025 00:00:53 +0200
Subject: [PATCH] Update _completions.py

- Avoids ambiguous if not
- Ensures only False leads to skipping chunks
-  Handles exceptions in handle_chunk() properly
---
 src/openai/lib/streaming/chat/_completions.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/openai/lib/streaming/chat/_completions.py b/src/openai/lib/streaming/chat/_completions.py
index a7b70c32d3..c3ee7d858f 100644
--- a/src/openai/lib/streaming/chat/_completions.py
+++ b/src/openai/lib/streaming/chat/_completions.py
@@ -236,9 +236,15 @@ def current_completion_snapshot(self) -> ParsedChatCompletionSnapshot:
 
     async def __stream__(self) -> AsyncIterator[ChatCompletionStreamEvent[ResponseFormatT]]:
         async for sse_event in self._raw_stream:
-            if not _is_valid_chat_completion_chunk_weak(sse_event):
+            valid = _is_valid_chat_completion_chunk_weak(sse_event)
+            if valid is False:
                 continue
-            events_to_fire = self._state.handle_chunk(sse_event)
+    
+            try:
+                events_to_fire = self._state.handle_chunk(sse_event)
+            except Exception as e:
+                raise RuntimeError("Stream processing failed while handling a chunk") from e
+    
             for event in events_to_fire:
                 yield event