Skip to content

Commit 8b73706

Browse files
committed
update to only sanitize package name
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
1 parent e4c9cf5 commit 8b73706

File tree

4 files changed

+12
-23
lines changed

4 files changed

+12
-23
lines changed

pkg/quarkus/v1alpha/init.go

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ import (
2121
"strings"
2222

2323
"github.com/operator-framework/java-operator-plugins/pkg/quarkus/v1alpha/scaffolds"
24-
"github.com/operator-framework/java-operator-plugins/pkg/quarkus/v1alpha/util"
2524
"github.com/spf13/pflag"
2625
"k8s.io/apimachinery/pkg/util/validation"
2726

@@ -47,12 +46,11 @@ type initSubcommand struct {
4746
commandName string
4847

4948
// Flags
50-
group string
51-
domain string
52-
version string
53-
kind string
54-
projectName string
55-
sanitizeDomain bool
49+
group string
50+
domain string
51+
version string
52+
kind string
53+
projectName string
5654
}
5755

5856
var (
@@ -79,20 +77,13 @@ func (p *initSubcommand) BindFlags(fs *pflag.FlagSet) {
7977
fs.StringVar(&p.group, groupFlag, "", "resource Group")
8078
fs.StringVar(&p.version, versionFlag, "", "resource Version")
8179
fs.StringVar(&p.kind, kindFlag, "", "resource Kind")
82-
83-
fs.BoolVar(&p.sanitizeDomain, "sanitize-domain", true, "whether or not the domain should be sanitized to produce a legal Java package name")
8480
p.apiSubcommand.BindFlags(fs)
8581
}
8682

8783
func (p *initSubcommand) InjectConfig(c config.Config) error {
8884
p.config = c
8985

90-
domain := p.domain
91-
92-
if p.sanitizeDomain {
93-
domain = util.SanitizeDomain(p.domain)
94-
}
95-
if err := p.config.SetDomain(domain); err != nil {
86+
if err := p.config.SetDomain(p.domain); err != nil {
9687
return err
9788
}
9889

pkg/quarkus/v1alpha/init_test.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ var _ = Describe("v1", func() {
3535

3636
BeforeEach(func() {
3737
successInitSubcommand = initSubcommand{
38-
domain: "testDomain",
39-
sanitizeDomain: true,
38+
domain: "testDomain",
4039
}
4140

4241
failureInitSubcommand = initSubcommand{
@@ -67,7 +66,6 @@ var _ = Describe("v1", func() {
6766
Expect(successInitSubcommand.group).To(Equal(""))
6867
Expect(successInitSubcommand.version).To(Equal(""))
6968
Expect(successInitSubcommand.kind).To(Equal(""))
70-
Expect(successInitSubcommand.sanitizeDomain).To(BeTrue())
7169
})
7270
})
7371

pkg/quarkus/v1alpha/scaffolds/api.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,19 +62,19 @@ func (s *apiScaffolder) Scaffold() error {
6262
var createAPITemplates []machinery.Builder
6363
createAPITemplates = append(createAPITemplates,
6464
&model.Model{
65-
Package: util.ReverseDomain(s.config.GetDomain()),
65+
Package: util.ReverseDomain(util.SanitizeDomain(s.config.GetDomain())),
6666
ClassName: util.ToClassname(s.resource.Kind),
6767
},
6868
&model.ModelSpec{
69-
Package: util.ReverseDomain(s.config.GetDomain()),
69+
Package: util.ReverseDomain(util.SanitizeDomain(s.config.GetDomain())),
7070
ClassName: util.ToClassname(s.resource.Kind),
7171
},
7272
&model.ModelStatus{
73-
Package: util.ReverseDomain(s.config.GetDomain()),
73+
Package: util.ReverseDomain(util.SanitizeDomain(s.config.GetDomain())),
7474
ClassName: util.ToClassname(s.resource.Kind),
7575
},
7676
&controller.Controller{
77-
Package: util.ReverseDomain(s.config.GetDomain()),
77+
Package: util.ReverseDomain(util.SanitizeDomain(s.config.GetDomain())),
7878
ClassName: util.ToClassname(s.resource.Kind),
7979
},
8080
)

pkg/quarkus/v1alpha/scaffolds/init.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ func (s *initScaffolder) Scaffold() error {
7171
}
7272
return scaffold.Execute(
7373
&templates.PomXmlFile{
74-
Package: util.ReverseDomain(s.config.GetDomain()),
74+
Package: util.ReverseDomain(util.SanitizeDomain(s.config.GetDomain())),
7575
ProjectName: s.config.GetProjectName(),
7676
OperatorVersion: "0.0.1",
7777
},

0 commit comments

Comments
 (0)