feat: revert use of canonical class name as default controller name

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/ResourceController.java

@@ -66,14 +66,14 @@ static String getDefaultNameFor(ResourceController controller) {
   }
 
   static String getDefaultNameFor(Class<? extends ResourceController> controllerClass) {
-    return getDefaultResourceControllerName(controllerClass.getCanonicalName());
+    return getDefaultResourceControllerName(controllerClass.getSimpleName());
   }
 
   static String getDefaultResourceControllerName(String rcControllerClassName) {
-    if (rcControllerClassName.indexOf('.') < 0) {
-      throw new IllegalArgumentException(
-          "Must provide a fully-qualified resource controller class name, was: "
-              + rcControllerClassName);
+    // if the name is fully qualified, extract the simple class name
+    final var lastDot = rcControllerClassName.lastIndexOf('.');
+    if (lastDot > 0) {
+      rcControllerClassName = rcControllerClassName.substring(lastDot);
     }
     return rcControllerClassName.toLowerCase(Locale.ROOT);
   }

operator-framework-quarkus-extension/deployment/src/main/java/io/javaoperatorsdk/quarkus/extension/deployment/QuarkusExtensionProcessor.java

@@ -143,8 +143,9 @@ private ControllerConfiguration createControllerConfiguration(
                 controllerAnnotation,
                 "name",
                 AnnotationValue::asString,
-                () -> ResourceController
-                    .getDefaultResourceControllerName(resourceControllerClassName)),
+                () ->
+                    ResourceController.getDefaultResourceControllerName(
+                        resourceControllerClassName)),
             crdName,
             valueOrDefault(
                 controllerAnnotation,
@@ -163,11 +164,11 @@ private ControllerConfiguration createControllerConfiguration(
                     controllerAnnotation,
                     "namespaces",
                     AnnotationValue::asStringArray,
-                    () -> new String[]{})),
+                    () -> new String[] {})),
             crType,
             doneableClassName,
             null // todo: fix-me
-        );
+            );
 
     return configuration;
   }

operator-framework-spring-boot-starter/src/test/java/io/javaoperatorsdk/operator/springboot/starter/TestController.java

@@ -9,7 +9,7 @@
 import org.springframework.stereotype.Component;
 
 @Component
-@Controller(crdName = "name", name = "name_must_be_changed")
+@Controller(crdName = "name")
 public class TestController implements ResourceController {
 
   @Override

operator-framework-spring-boot-starter/src/test/resources/application.yaml

@@ -5,7 +5,7 @@ javaoperatorsdk:
     masterUrl: http://master.url
 
   controllers:
-    name_must_be_changed:
+    testcontroller:
       retry:
         maxAttempts: 3
         initialInterval: 1000