fix: potential performance issue

metacosm · metacosm · commit 9df916f10cf1 · 2021-10-28T12:56:50.000+02:00
diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/ControllerConfigurationOverrider.java
@@ -48,7 +48,7 @@ public ControllerConfigurationOverrider<R> addingNamespaces(String... namespaces
   }
 
   public ControllerConfigurationOverrider<R> removingNamespaces(String... namespaces) {
-    this.namespaces.removeAll(List.of(namespaces));
+    List.of(namespaces).forEach(this.namespaces::remove);
     return this;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public ControllerConfigurationOverrider<R> addingNamespaces(String... namespaces`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`public ControllerConfigurationOverrider<R> removingNamespaces(String... namespaces) {`
`51`		`- this.namespaces.removeAll(List.of(namespaces));`
	`51`	`+ List.of(namespaces).forEach(this.namespaces::remove);`
`52`	`52`	`return this;`
`53`	`53`	`}`
`54`	`54`