feat: removing Event using DefaultEvent instead, renamed DefaultEvent to Event.

- EventHandler is not closeable

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/DefaultEventHandler.java

@@ -1,5 +1,6 @@
 package io.javaoperatorsdk.operator.processing;
 
+import java.io.Closeable;
 import java.util.HashMap;
 import java.util.HashSet;
 import java.util.Map;
@@ -17,10 +18,7 @@
 import io.javaoperatorsdk.operator.api.config.ConfigurationService;
 import io.javaoperatorsdk.operator.api.config.ExecutorServiceManager;
 import io.javaoperatorsdk.operator.api.monitoring.Metrics;
-import io.javaoperatorsdk.operator.processing.event.CustomResourceID;
-import io.javaoperatorsdk.operator.processing.event.DefaultEventSourceManager;
-import io.javaoperatorsdk.operator.processing.event.Event;
-import io.javaoperatorsdk.operator.processing.event.EventHandler;
+import io.javaoperatorsdk.operator.processing.event.*;
 import io.javaoperatorsdk.operator.processing.event.internal.CustomResourceEvent;
 import io.javaoperatorsdk.operator.processing.event.internal.ResourceAction;
 import io.javaoperatorsdk.operator.processing.retry.GenericRetry;
@@ -34,7 +32,8 @@
  * Event handler that makes sure that events are processed in a "single threaded" way per resource
  * UID, while buffering events which are received during an execution.
  */
-public class DefaultEventHandler<R extends CustomResource<?, ?>> implements EventHandler {
+public class DefaultEventHandler<R extends CustomResource<?, ?>>
+    implements EventHandler, Closeable {
 
   private static final Logger log = LoggerFactory.getLogger(DefaultEventHandler.class);
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/DefaultEvent.java

@@ -1,7 +1,22 @@
 package io.javaoperatorsdk.operator.processing.event;
 
-public interface Event {
+@SuppressWarnings("rawtypes")
+public class Event {
 
-  CustomResourceID getRelatedCustomResourceID();
+  private final CustomResourceID relatedCustomResource;
 
+  public Event(CustomResourceID targetCustomResource) {
+    this.relatedCustomResource = targetCustomResource;
+  }
+
+  public CustomResourceID getRelatedCustomResourceID() {
+    return relatedCustomResource;
+  }
+
+  @Override
+  public String toString() {
+    return "DefaultEvent{" +
+        "relatedCustomResource=" + relatedCustomResource +
+        '}';
+  }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/Event.java

@@ -1,12 +1,7 @@
 package io.javaoperatorsdk.operator.processing.event;
 
-import java.io.Closeable;
-import java.io.IOException;
-
-public interface EventHandler extends Closeable {
+public interface EventHandler {
 
   void handleEvent(Event event);
 
-  @Override
-  default void close() throws IOException {}
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventHandler.java

@@ -1,9 +1,9 @@
 package io.javaoperatorsdk.operator.processing.event.internal;
 
 import io.javaoperatorsdk.operator.processing.event.CustomResourceID;
-import io.javaoperatorsdk.operator.processing.event.DefaultEvent;
+import io.javaoperatorsdk.operator.processing.event.Event;
 
-public class CustomResourceEvent extends DefaultEvent {
+public class CustomResourceEvent extends Event {
 
   private final ResourceAction action;
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEvent.java

@@ -106,7 +106,6 @@ public void start() {
 
   @Override
   public void close() throws IOException {
-    eventHandler.close();
     for (SharedIndexInformer<T> informer : sharedIndexInformers.values()) {
       try {
         log.info("Closing informer {} -> {}", controller, informer);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java

@@ -13,7 +13,7 @@
 import io.fabric8.kubernetes.client.informers.cache.Store;
 import io.javaoperatorsdk.operator.processing.event.AbstractEventSource;
 import io.javaoperatorsdk.operator.processing.event.CustomResourceID;
-import io.javaoperatorsdk.operator.processing.event.DefaultEvent;
+import io.javaoperatorsdk.operator.processing.event.Event;
 
 public class InformerEventSource<T extends HasMetadata> extends AbstractEventSource {
 
@@ -82,7 +82,7 @@ private void propagateEvent(T object) {
       return;
     }
     uids.forEach(uid -> {
-      DefaultEvent event = new DefaultEvent(CustomResourceID.fromResource(object));
+      Event event = new Event(CustomResourceID.fromResource(object));
       this.eventHandler.handleEvent(event);
     });
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/InformerEventSource.java

@@ -13,7 +13,7 @@
 import io.fabric8.kubernetes.client.CustomResource;
 import io.javaoperatorsdk.operator.processing.event.AbstractEventSource;
 import io.javaoperatorsdk.operator.processing.event.CustomResourceID;
-import io.javaoperatorsdk.operator.processing.event.DefaultEvent;
+import io.javaoperatorsdk.operator.processing.event.Event;
 
 public class TimerEventSource<R extends CustomResource<?, ?>> extends AbstractEventSource {
   private static final Logger log = LoggerFactory.getLogger(TimerEventSource.class);
@@ -95,7 +95,7 @@ public EventProducerTimeTask(CustomResourceID customResourceUid) {
     public void run() {
       if (running.get()) {
         log.debug("Producing event for custom resource id: {}", customResourceUid);
-        eventHandler.handleEvent(new DefaultEvent(customResourceUid));
+        eventHandler.handleEvent(new Event(customResourceUid));
       }
     }
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/TimerEventSource.java

@@ -13,7 +13,6 @@
 
 import io.fabric8.kubernetes.client.CustomResource;
 import io.javaoperatorsdk.operator.processing.event.CustomResourceID;
-import io.javaoperatorsdk.operator.processing.event.DefaultEvent;
 import io.javaoperatorsdk.operator.processing.event.DefaultEventSourceManager;
 import io.javaoperatorsdk.operator.processing.event.Event;
 import io.javaoperatorsdk.operator.processing.event.internal.CustomResourceEvent;
@@ -315,7 +314,7 @@ private CustomResourceEvent prepareCREvent(CustomResourceID uid) {
   }
 
   private Event nonCREvent(CustomResourceID relatedCustomResourceUid) {
-    return new DefaultEvent(relatedCustomResourceUid);
+    return new Event(relatedCustomResourceUid);
   }
 
   private void overrideData(CustomResourceID id, CustomResource<?, ?> applyTo) {