fix: test now uses REST app to verify that beans are properly injected

This is needed because we cannot currently use QuarkusUnitTest because
of an issue with the kubernetes extension and it's not possible to
inject beans in a test using QuarkusProdModeTest. The workaround then is
to create a separate app that's started using QuarkusProdModeTest and
that exposes some information that we can check over REST about the
injected beans to verify that they are indeed properly injected.

Author: metacosm

operator-framework-quarkus-extension/deployment/pom.xml

@@ -48,6 +48,21 @@
             <artifactId>quarkus-junit5-internal</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>io.rest-assured</groupId>
+            <artifactId>rest-assured</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.assertj</groupId>
+            <artifactId>assertj-core</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>io.javaoperatorsdk</groupId>
+            <artifactId>operator-framework-quarkus-tests-support</artifactId>
+            <version>${project.version}</version>
+        </dependency>
     </dependencies>
 
     <build>

operator-framework-quarkus-extension/deployment/src/test/java/io/javaoperatorsdk/quarkus/extension/deployment/QuarkusExtensionProcessorTest.java

@@ -1,32 +1,60 @@
 package io.javaoperatorsdk.quarkus.extension.deployment;
 
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static io.restassured.RestAssured.given;
+import static org.hamcrest.Matchers.equalTo;
+import static org.hamcrest.Matchers.is;
 
-import io.javaoperatorsdk.operator.api.config.ConfigurationService;
+import io.javaoperatorsdk.quarkus.it.TestController;
+import io.javaoperatorsdk.quarkus.it.TestOperatorApp;
+import io.javaoperatorsdk.quarkus.it.TestResource;
 import io.quarkus.test.QuarkusProdModeTest;
-import javax.inject.Inject;
 import org.jboss.shrinkwrap.api.ShrinkWrap;
 import org.jboss.shrinkwrap.api.spec.JavaArchive;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
+/**
+ * This tests creates an application based on the application code found in the {@code
+ * operator-framework-quarkus-tests-support} module. The app is started and accessed over REST to
+ * assess that injected values are present and what we expect.
+ */
 public class QuarkusExtensionProcessorTest {
 
   @RegisterExtension
   static final QuarkusProdModeTest config =
       new QuarkusProdModeTest()
           .setArchiveProducer(
-              () -> ShrinkWrap.create(JavaArchive.class).addClasses(TestController.class))
+              () ->
+                  ShrinkWrap.create(JavaArchive.class)
+                      .addClasses(TestOperatorApp.class, TestController.class))
           .setApplicationName("basic-app")
-          .setApplicationVersion("0.1-SNAPSHOT");
+          .setApplicationVersion("0.1-SNAPSHOT")
+          .setRun(true);
 
-  @Inject TestController controller;
-  @Inject ConfigurationService configurationService;
+  @Test
+  void controllerShouldExist() {
+    // first check that we're not always returning true for any controller name :)
+    given().when().get("/operator/does_not_exist").then().statusCode(200).body(is("false"));
+
+    // given the name of the TestController, the app should reply true meaning that it is indeed
+    // injected
+    given().when().get("/operator/" + TestController.NAME).then().statusCode(200).body(is("true"));
+  }
 
   @Test
-  void test() {
-    assertNotNull(controller);
-    assertNotNull(configurationService);
-    assertNotNull(configurationService.getConfigurationFor(controller));
+  void configurationForControllerShouldExist() {
+    // check that the config for the test controller can be retrieved and is conform to our
+    // expectations
+    final var resourceName = TestResource.class.getCanonicalName();
+    given()
+        .when()
+        .get("/operator/" + TestController.NAME + "/config")
+        .then()
+        .statusCode(200)
+        .body(
+            "customResourceClass", equalTo(resourceName),
+            "doneableClass", equalTo(resourceName + "Doneable"),
+            "name", equalTo(TestController.NAME),
+            "crdName", equalTo(TestController.CRD_NAME));
   }
 }

operator-framework-quarkus-extension/pom.xml

@@ -27,6 +27,7 @@
   <modules>
     <module>deployment</module>
     <module>runtime</module>
+    <module>tests</module>
   </modules>
   <dependencyManagement>
     <dependencies>

operator-framework-quarkus-extension/tests/pom.xml

@@ -0,0 +1,56 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+  <parent>
+    <artifactId>operator-framework-quarkus-extension-parent</artifactId>
+    <groupId>io.javaoperatorsdk</groupId>
+    <version>1.6.2-SNAPSHOT</version>
+  </parent>
+  <modelVersion>4.0.0</modelVersion>
+
+  <artifactId>operator-framework-quarkus-tests-support</artifactId>
+  <name>Operator SDK - Quarkus Extension - Tests Support</name>
+
+
+  <properties>
+    <maven.compiler.source>11</maven.compiler.source>
+    <maven.compiler.target>11</maven.compiler.target>
+  </properties>
+
+  <dependencies>
+    <dependency>
+      <groupId>io.javaoperatorsdk</groupId>
+      <artifactId>operator-framework-quarkus-extension</artifactId>
+      <version>${project.version}</version>
+    </dependency>
+    <dependency>
+      <groupId>io.quarkus</groupId>
+      <artifactId>quarkus-resteasy-jackson</artifactId>
+    </dependency>
+  </dependencies>
+
+  <build>
+    <plugins>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <configuration>
+          <parameters>true</parameters>
+        </configuration>
+      </plugin>
+      <plugin>
+        <groupId>io.quarkus</groupId>
+        <artifactId>quarkus-maven-plugin</artifactId>
+        <version>${quarkus.version}</version>
+        <executions>
+          <execution>
+            <goals>
+              <goal>build</goal>
+            </goals>
+          </execution>
+        </executions>
+      </plugin>
+    </plugins>
+  </build>
+</project>

operator-framework-quarkus-extension/deployment/src/test/java/io/javaoperatorsdk/quarkus/extension/deployment/TestController.java renamed to operator-framework-quarkus-extension/tests/src/main/java/io/javaoperatorsdk/quarkus/it/TestController.java

@@ -1,13 +1,15 @@
-package io.javaoperatorsdk.quarkus.extension.deployment;
+package io.javaoperatorsdk.quarkus.it;
 
 import io.javaoperatorsdk.operator.api.Context;
 import io.javaoperatorsdk.operator.api.Controller;
 import io.javaoperatorsdk.operator.api.DeleteControl;
 import io.javaoperatorsdk.operator.api.ResourceController;
 import io.javaoperatorsdk.operator.api.UpdateControl;
 
-@Controller(crdName = "test.example.com")
+@Controller(crdName = TestController.CRD_NAME, name = TestController.NAME)
 public class TestController implements ResourceController<TestResource> {
+  public static final String NAME = "test";
+  public static final String CRD_NAME = "test.example.com";
 
   @Override
   public DeleteControl deleteResource(TestResource resource, Context<TestResource> context) {

operator-framework-quarkus-extension/tests/src/main/java/io/javaoperatorsdk/quarkus/it/TestOperatorApp.java

@@ -0,0 +1,28 @@
+package io.javaoperatorsdk.quarkus.it;
+
+import io.javaoperatorsdk.operator.api.config.ConfigurationService;
+import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
+import javax.inject.Inject;
+import javax.ws.rs.GET;
+import javax.ws.rs.Path;
+import javax.ws.rs.PathParam;
+
+@Path("/operator")
+public class TestOperatorApp {
+
+  @Inject TestController controller;
+  @Inject ConfigurationService configurationService;
+
+  @GET
+  @Path("{name}")
+  //  @Produces(MediaType.TEXT_PLAIN)
+  public boolean getController(@PathParam("name") String name) {
+    return name.equals(controller.getName());
+  }
+
+  @GET
+  @Path("{name}/config")
+  public ControllerConfiguration getConfig(@PathParam("name") String name) {
+    return getController(name) ? configurationService.getConfigurationFor(controller) : null;
+  }
+}

operator-framework-quarkus-extension/deployment/src/main/java/io/javaoperatorsdk/quarkus/extension/deployment/TestResource.java renamed to operator-framework-quarkus-extension/tests/src/main/java/io/javaoperatorsdk/quarkus/it/TestResource.java

@@ -1,4 +1,4 @@
-package io.javaoperatorsdk.quarkus.extension.deployment;
+package io.javaoperatorsdk.quarkus.it;
 
 import io.fabric8.kubernetes.client.CustomResource;