Skip to content

Commit c012114

Browse files
authored
Merge pull request #275 from java-operator-sdk/fix-uncheck-warnings
Fix uncheck warnings
2 parents 6bf683f + 11a8c8c commit c012114

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

operator-framework/src/main/java/io/javaoperatorsdk/operator/config/runtime/ControllerAnnotationProcessor.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import static io.javaoperatorsdk.operator.config.runtime.RuntimeControllerMetadata.DONEABLES_RESOURCE_PATH;
55

66
import com.google.auto.service.AutoService;
7+
import com.squareup.javapoet.AnnotationSpec;
78
import com.squareup.javapoet.ClassName;
89
import com.squareup.javapoet.JavaFile;
910
import com.squareup.javapoet.MethodSpec;
@@ -35,7 +36,7 @@
3536
import javax.tools.JavaFileObject;
3637

3738
@SupportedAnnotationTypes("io.javaoperatorsdk.operator.api.Controller")
38-
@SupportedSourceVersion(SourceVersion.RELEASE_8)
39+
@SupportedSourceVersion(SourceVersion.RELEASE_11)
3940
@AutoService(Processor.class)
4041
public class ControllerAnnotationProcessor extends AbstractProcessor {
4142

@@ -106,12 +107,8 @@ private void generateDoneableClass(TypeElement controllerClassSymbol) {
106107
controllersResourceWriter.add(
107108
controllerClassSymbol.getQualifiedName().toString(),
108109
CustomResource.class.getCanonicalName());
109-
return;
110-
}
111-
112-
if (resourceType == null) {
113110
System.out.println(
114-
"No defined a resource type for '"
111+
"No defined resource type for '"
115112
+ controllerClassSymbol.getQualifiedName()
116113
+ "': ignoring!");
117114
return;
@@ -149,6 +146,10 @@ private void generateDoneableClass(TypeElement controllerClassSymbol) {
149146
.addParameter(customResourceType, "resource")
150147
.addParameter(Function.class, "function")
151148
.addStatement("super(resource,function)")
149+
.addAnnotation(
150+
AnnotationSpec.builder(SuppressWarnings.class)
151+
.addMember("value", "$S", "unchecked")
152+
.build())
152153
.build();
153154

154155
final TypeSpec typeSpec =

operator-framework/src/test/resources/compile-fixtures/ControllerImplemented2InterfacesExpected.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22

33
import io.fabric8.kubernetes.api.builder.Function;
44
import io.fabric8.kubernetes.client.CustomResourceDoneable;
5+
import java.lang.SuppressWarnings;
56

67
public class MyCustomResourceDoneable extends CustomResourceDoneable<ControllerImplemented2Interfaces.MyCustomResource> {
8+
@SuppressWarnings("unchecked")
79
public MyCustomResourceDoneable(ControllerImplemented2Interfaces.MyCustomResource resource, Function function) {
810
super(resource, function);
911
}

operator-framework/src/test/resources/compile-fixtures/ControllerImplementedIntermediateAbstractClassExpected.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22

33
import io.fabric8.kubernetes.api.builder.Function;
44
import io.fabric8.kubernetes.client.CustomResourceDoneable;
5+
import java.lang.SuppressWarnings;
56

67
public class MyCustomResourceDoneable extends CustomResourceDoneable<AbstractController.MyCustomResource> {
8+
@SuppressWarnings("unchecked")
79
public MyCustomResourceDoneable(AbstractController.MyCustomResource resource, Function function) {
810
super(resource, function);
911
}

operator-framework/src/test/resources/compile-fixtures/MultilevelControllerExpected.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@
22

33
import io.fabric8.kubernetes.api.builder.Function;
44
import io.fabric8.kubernetes.client.CustomResourceDoneable;
5+
import java.lang.SuppressWarnings;
56

67
public class MyCustomResourceDoneable extends CustomResourceDoneable<MultilevelController.MyCustomResource> {
8+
@SuppressWarnings("unchecked")
79
public MyCustomResourceDoneable(MultilevelController.MyCustomResource resource, Function function) {
810
super(resource, function);
911
}

0 commit comments

Comments
 (0)