fix: misleading MissingCRDException exception #552

Author: lburgazzoli

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ConfiguredController.java

@@ -174,12 +174,8 @@ public void start() throws OperatorException {
       CustomResourceUtils.assertCustomResource(resClass, crd);
     }
 
-    try {
-      DefaultEventSourceManager<R> eventSourceManager = new DefaultEventSourceManager<>(this);
-      controller.init(eventSourceManager);
-    } catch (MissingCRDException e) {
-      throwMissingCRDException(crdName, specVersion, controllerName);
-    }
+    DefaultEventSourceManager<R> eventSourceManager = new DefaultEventSourceManager<>(this);
+    controller.init(eventSourceManager);
 
     if (failOnMissingCurrentNS()) {
       throw new OperatorException(

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/DefaultEventSourceManager.java

@@ -15,8 +15,6 @@
 import org.slf4j.LoggerFactory;
 
 import io.fabric8.kubernetes.client.CustomResource;
-import io.fabric8.kubernetes.client.KubernetesClientException;
-import io.javaoperatorsdk.operator.MissingCRDException;
 import io.javaoperatorsdk.operator.OperatorException;
 import io.javaoperatorsdk.operator.processing.ConfiguredController;
 import io.javaoperatorsdk.operator.processing.CustomResourceCache;
@@ -89,12 +87,6 @@ public final void registerEventSource(String name, EventSource eventSource)
         // leave untouched
         throw e;
       }
-      if (e instanceof KubernetesClientException) {
-        KubernetesClientException ke = (KubernetesClientException) e;
-        if (404 == ke.getCode()) {
-          throw new MissingCRDException(null, null);
-        }
-      }
       throw new OperatorException("Couldn't register event source named '" + name + "'", e);
     } finally {
       lock.unlock();