refactor: rename methods so that it's clearer they're not about caching

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/ResourceOwner.java

@@ -14,7 +14,9 @@ public interface ResourceOwner<R, P extends HasMetadata> {
   Class<R> resourceType();
 
   /**
-   * Retrieves the resource associated with the specified primary one
+   * Retrieves the resource associated with the specified primary one, returning the actual state of
+   * the resource. Typically, this state might come from a local cache, updated after
+   * reconciliation.
    *
    * @param primary the primary resource for which we want to retrieve the secondary resource
    * @return an {@link Optional} containing the secondary resource or {@link Optional#empty()} if it

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractDependentResource.java

@@ -71,18 +71,34 @@ private void logForOperation(String operation, P primary, R desired) {
   protected R handleCreate(R desired, P primary, Context<P> context) {
     ResourceID resourceID = ResourceID.fromResource(primary);
     R created = creator.create(desired, primary, context);
-    cacheAfterCreate(resourceID, created);
+    processPostCreate(resourceID, created);
     return created;
   }
 
-  protected abstract void cacheAfterCreate(ResourceID resourceID, R created);
+  /**
+   * Allows sub-classes to perform additional processing (e.g. caching) on the created resource if
+   * needed.
+   *
+   * @param primaryResourceId the {@link ResourceID} of the primary resource associated with the
+   *        newly created resource
+   * @param created the newly created resource
+   */
+  protected abstract void processPostCreate(ResourceID primaryResourceId, R created);
 
-  protected abstract void cacheAfterUpdate(R actual, ResourceID resourceID, R updated);
+  /**
+   * Allows sub-classes to perform additional processing on the updated resource if needed.
+   *
+   * @param primaryResourceId the {@link ResourceID} of the primary resource associated with the
+   *        newly updated resource
+   * @param updated the updated resource
+   * @param actual the resource as it was before the update
+   */
+  protected abstract void processPostUpdate(ResourceID primaryResourceId, R updated, R actual);
 
   protected R handleUpdate(R actual, R desired, P primary, Context<P> context) {
     ResourceID resourceID = ResourceID.fromResource(primary);
     R updated = updater.update(actual, desired, primary, context);
-    cacheAfterUpdate(actual, resourceID, updated);
+    processPostUpdate(resourceID, updated, actual);
     return updated;
   }
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/AbstractEventSourceHolderDependentResource.java

@@ -86,15 +86,15 @@ protected R handleUpdate(R actual, R desired, P primary, Context<P> context) {
   }
 
 
-  protected void cacheAfterCreate(ResourceID resourceID, R created) {
+  protected void processPostCreate(ResourceID primaryResourceId, R created) {
     if (isCacheFillerEventSource) {
-      recentOperationCacheFiller().handleRecentResourceCreate(resourceID, created);
+      recentOperationCacheFiller().handleRecentResourceCreate(primaryResourceId, created);
     }
   }
 
-  protected void cacheAfterUpdate(R actual, ResourceID resourceID, R updated) {
+  protected void processPostUpdate(ResourceID primaryResourceId, R updated, R actual) {
     if (isCacheFillerEventSource) {
-      recentOperationCacheFiller().handleRecentResourceUpdate(resourceID, updated, actual);
+      recentOperationCacheFiller().handleRecentResourceUpdate(primaryResourceId, updated, actual);
     }
   }
 

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/external/AbstractSimpleDependentResource.java

@@ -59,13 +59,13 @@ public final void delete(P primary, Context<P> context) {
   protected abstract void deleteResource(P primary, Context<P> context);
 
   @Override
-  protected void cacheAfterCreate(ResourceID resourceID, R created) {
-    cache.put(resourceID, created);
+  protected void processPostCreate(ResourceID primaryResourceId, R created) {
+    cache.put(primaryResourceId, created);
   }
 
   @Override
-  protected void cacheAfterUpdate(R actual, ResourceID resourceID, R updated) {
-    cache.put(resourceID, updated);
+  protected void processPostUpdate(ResourceID primaryResourceId, R updated, R actual) {
+    cache.put(primaryResourceId, updated);
   }
 
   public Matcher.Result<R> match(R actualResource, P primary, Context<P> context) {

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

@@ -165,8 +165,7 @@ public InformerConfiguration<R, P> getConfiguration() {
   public synchronized void handleRecentResourceUpdate(ResourceID resourceID, R resource,
       R previousResourceVersion) {
     handleRecentCreateOrUpdate(resource,
-        () -> super.handleRecentResourceUpdate(resourceID, resource,
-            previousResourceVersion));
+        () -> super.handleRecentResourceUpdate(resourceID, resource, previousResourceVersion));
   }
 
   @Override