diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java index 3ec615ffcb..a2105cac11 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/InformerConfiguration.java @@ -7,7 +7,6 @@ import io.fabric8.kubernetes.api.model.HasMetadata; import io.javaoperatorsdk.operator.api.config.DefaultResourceConfiguration; import io.javaoperatorsdk.operator.api.config.ResourceConfiguration; -import io.javaoperatorsdk.operator.api.reconciler.EventSourceContext; import io.javaoperatorsdk.operator.processing.event.source.SecondaryToPrimaryMapper; import io.javaoperatorsdk.operator.processing.event.source.informer.Mappers; @@ -40,7 +39,7 @@ public SecondaryToPrimaryMapper getSecondaryToPrimaryMapper() { SecondaryToPrimaryMapper getSecondaryToPrimaryMapper(); @SuppressWarnings("unused") - class InformerConfigurationBuilder { + class InformerConfigurationBuilder { private SecondaryToPrimaryMapper secondaryToPrimaryMapper; private Set namespaces; @@ -51,24 +50,24 @@ private InformerConfigurationBuilder(Class resourceClass) { this.resourceClass = resourceClass; } - public InformerConfigurationBuilder withSecondaryToPrimaryMapper( + public InformerConfigurationBuilder withSecondaryToPrimaryMapper( SecondaryToPrimaryMapper secondaryToPrimaryMapper) { this.secondaryToPrimaryMapper = secondaryToPrimaryMapper; return this; } - public InformerConfigurationBuilder withNamespaces(String... namespaces) { + public InformerConfigurationBuilder withNamespaces(String... namespaces) { this.namespaces = namespaces != null ? Set.of(namespaces) : Collections.emptySet(); return this; } - public InformerConfigurationBuilder withNamespaces(Set namespaces) { + public InformerConfigurationBuilder withNamespaces(Set namespaces) { this.namespaces = namespaces != null ? namespaces : Collections.emptySet(); return this; } - public InformerConfigurationBuilder withLabelSelector(String labelSelector) { + public InformerConfigurationBuilder withLabelSelector(String labelSelector) { this.labelSelector = labelSelector; return this; } @@ -80,19 +79,15 @@ public InformerConfiguration build() { } } - static InformerConfigurationBuilder from( - EventSourceContext

context, Class resourceClass) { + static InformerConfigurationBuilder from( + Class resourceClass) { return new InformerConfigurationBuilder<>(resourceClass); } - @SuppressWarnings({"rawtypes", "unchecked"}) - static InformerConfigurationBuilder from(Class resourceClass) { - return new InformerConfigurationBuilder<>(resourceClass); - } - static InformerConfigurationBuilder from( + static InformerConfigurationBuilder from( InformerConfiguration configuration) { - return new InformerConfigurationBuilder(configuration.getResourceClass()) + return new InformerConfigurationBuilder(configuration.getResourceClass()) .withNamespaces(configuration.getNamespaces()) .withLabelSelector(configuration.getLabelSelector()) .withSecondaryToPrimaryMapper(configuration.getSecondaryToPrimaryMapper()); diff --git a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java index b5dd2a720a..ca0b94b230 100644 --- a/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java +++ b/operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/dependent/kubernetes/KubernetesDependentResource.java @@ -54,7 +54,7 @@ public void configureWith(KubernetesDependentResourceConfig config) { @SuppressWarnings("unchecked") private void configureWith(String labelSelector, Set namespaces) { - final var primaryResourcesRetriever = + final SecondaryToPrimaryMapper primaryResourcesRetriever = (this instanceof SecondaryToPrimaryMapper) ? (SecondaryToPrimaryMapper) this : Mappers.fromOwnerReference(); InformerConfiguration ic = diff --git a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/createupdateeventfilter/CreateUpdateEventFilterTestReconciler.java b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/createupdateeventfilter/CreateUpdateEventFilterTestReconciler.java index acfc109f72..256d861791 100644 --- a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/createupdateeventfilter/CreateUpdateEventFilterTestReconciler.java +++ b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/createupdateeventfilter/CreateUpdateEventFilterTestReconciler.java @@ -102,7 +102,7 @@ private ConfigMap createConfigMap(CreateUpdateEventFilterTestCustomResource reso public Map prepareEventSources( EventSourceContext context) { InformerConfiguration informerConfiguration = - InformerConfiguration.from(context, ConfigMap.class) + InformerConfiguration.from(ConfigMap.class) .withLabelSelector("integrationtest = " + this.getClass().getSimpleName()) .build(); informerEventSource = new InformerEventSource<>(informerConfiguration, client); diff --git a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/informereventsource/InformerEventSourceTestCustomReconciler.java b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/informereventsource/InformerEventSourceTestCustomReconciler.java index a4aa0f4ddd..fb9f2e1971 100644 --- a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/informereventsource/InformerEventSourceTestCustomReconciler.java +++ b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/informereventsource/InformerEventSourceTestCustomReconciler.java @@ -42,7 +42,7 @@ public Map prepareEventSources( EventSourceContext context) { InformerConfiguration config = - InformerConfiguration.from(context, ConfigMap.class) + InformerConfiguration.from(ConfigMap.class) .withSecondaryToPrimaryMapper(Mappers.fromAnnotation(RELATED_RESOURCE_NAME)) .build(); diff --git a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplesecondaryeventsource/MultipleSecondaryEventSourceReconciler.java b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplesecondaryeventsource/MultipleSecondaryEventSourceReconciler.java index ce27f0f363..29557b0a30 100644 --- a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplesecondaryeventsource/MultipleSecondaryEventSourceReconciler.java +++ b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/multiplesecondaryeventsource/MultipleSecondaryEventSourceReconciler.java @@ -66,7 +66,7 @@ public Map prepareEventSources( EventSourceContext context) { - var config = InformerConfiguration.from(context, ConfigMap.class) + var config = InformerConfiguration.from(ConfigMap.class) .withNamespaces(context.getControllerConfiguration().getNamespaces()) .withLabelSelector("multisecondary") .withSecondaryToPrimaryMapper(s -> { diff --git a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primaryindexer/PrimaryIndexerTestReconciler.java b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primaryindexer/PrimaryIndexerTestReconciler.java index 4d8fdbe9a2..6890a3c8c4 100644 --- a/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primaryindexer/PrimaryIndexerTestReconciler.java +++ b/operator-framework/src/test/java/io/javaoperatorsdk/operator/sample/primaryindexer/PrimaryIndexerTestReconciler.java @@ -24,7 +24,7 @@ public Map prepareEventSources( context.getPrimaryCache().addIndexer(CONFIG_MAP_RELATION_INDEXER, indexer); var informerConfiguration = - InformerConfiguration.from(context, ConfigMap.class) + InformerConfiguration.from(ConfigMap.class) .withSecondaryToPrimaryMapper( (ConfigMap secondaryResource) -> context .getPrimaryCache() diff --git a/sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java b/sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java index 697f72cfdd..ffd530713c 100644 --- a/sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java +++ b/sample-operators/tomcat-operator/src/main/java/io/javaoperatorsdk/operator/sample/WebappReconciler.java @@ -59,7 +59,7 @@ public Map prepareEventSources(EventSourceContext c .collect(Collectors.toSet()); InformerConfiguration configuration = - InformerConfiguration.from(context, Tomcat.class) + InformerConfiguration.from(Tomcat.class) .withSecondaryToPrimaryMapper(webappsMatchingTomcatName) .build(); return EventSourceInitializer diff --git a/sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java b/sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java index 5bccefb56e..7ff94edc4b 100644 --- a/sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java +++ b/sample-operators/webpage/src/main/java/io/javaoperatorsdk/operator/sample/WebPageReconciler.java @@ -51,19 +51,19 @@ public WebPageReconciler(KubernetesClient kubernetesClient) { @Override public Map prepareEventSources(EventSourceContext context) { var configMapEventSource = - new InformerEventSource<>(InformerConfiguration.from(context, ConfigMap.class) + new InformerEventSource<>(InformerConfiguration.from(ConfigMap.class) .withLabelSelector(LOW_LEVEL_LABEL_KEY) .build(), context); var deploymentEventSource = - new InformerEventSource<>(InformerConfiguration.from(context, Deployment.class) + new InformerEventSource<>(InformerConfiguration.from(Deployment.class) .withLabelSelector(LOW_LEVEL_LABEL_KEY) .build(), context); var serviceEventSource = - new InformerEventSource<>(InformerConfiguration.from(context, Service.class) + new InformerEventSource<>(InformerConfiguration.from(Service.class) .withLabelSelector(LOW_LEVEL_LABEL_KEY) .build(), context); var ingressEventSource = - new InformerEventSource<>(InformerConfiguration.from(context, Ingress.class) + new InformerEventSource<>(InformerConfiguration.from(Ingress.class) .withLabelSelector(LOW_LEVEL_LABEL_KEY) .build(), context); return EventSourceInitializer.nameEventSources(configMapEventSource, deploymentEventSource,