-
-
Notifications
You must be signed in to change notification settings - Fork 145
Run Pyrefly on pandas-stubs in CI #1263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One thing to consider. In CI, we have tests that separately test the stubs locally, but also test them when installed (for Let me know what you think about this. |
I was thinking that we test the installed stubs once we're able to check the We're still some ways off from being able to do that (there are a few hundred false positives right now), so I figured we could run it on just the stubs for now and still get some value out of it. Wdyt? |
OK - that's fine by me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @yangdanny97
@yangdanny97 I'm going to assume that if new versions of |
Similar to #1240, this PR adds Pyrefly to run on just the stubs directory, since there are very few false-positives now (I've filed facebook/pyrefly#569 to address some of these).
I tested the CI and added the suppressions on my fork here: yangdanny97#1
There are some known gaps that prevent us from checking the tests directory without a lot of false-positives, so that can be saved for later.