From 385f9b559a33d89e9d86e7e1cd62ed06d4236651 Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Wed, 9 Feb 2022 08:58:09 +0100 Subject: [PATCH 1/8] add "--no-build-isolation" to pip install --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 8887e80566772..34a13e69d73d2 100644 --- a/Dockerfile +++ b/Dockerfile @@ -45,4 +45,4 @@ RUN . /opt/conda/etc/profile.d/conda.sh \ && cd "$pandas_home" \ && export \ && python setup.py build_ext -j 4 \ - && python -m pip install -e . + && python -m pip install --no-build-isolation -e . From 83e78a9db328cb46b5b847f41226b70ee4a8e04c Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Sat, 12 Feb 2022 22:58:53 +0100 Subject: [PATCH 2/8] add job "build_docker_dev_environment" --- .github/workflows/code-checks.yml | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 8a74ae14404b3..81fe6c9cf0bfc 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -156,3 +156,24 @@ jobs: name: Benchmarks log path: asv_bench/benchmarks.log if: failure() + + build_docker_dev_environment: + name: Build Docker Dev Environment + runs-on: ubuntu-latest + defaults: + run: + shell: bash -l {0} + + concurrency: + # https://github.community/t/concurrecy-not-work-for-push/183068/7 + group: ${{ github.event_name == 'push' && github.run_number || github.ref }}-pre-commit + cancel-in-progress: true + + steps: + - name: Checkout + uses: actions/checkout@v2 + with: + fetch-depth: 0 + + - name: Build Docker Image + run: docker build --no-cache --tag pandas-dev-env . From a27c70abec16a8402a5c7e843058badcb3148b81 Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Sat, 12 Feb 2022 23:23:58 +0100 Subject: [PATCH 3/8] Trigger Build From 22e17ff1b58cc43404f9bf53f37792d4fc8fc3a0 Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Sun, 13 Feb 2022 00:15:43 +0100 Subject: [PATCH 4/8] fix wrong group name --- .github/workflows/code-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 81fe6c9cf0bfc..a106208934591 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -166,7 +166,7 @@ jobs: concurrency: # https://github.community/t/concurrecy-not-work-for-push/183068/7 - group: ${{ github.event_name == 'push' && github.run_number || github.ref }}-pre-commit + group: ${{ github.event_name == 'push' && github.run_number || github.ref }}-build_docker_dev_environment cancel-in-progress: true steps: From 76331c78f278c5e145b4baf33bfa31057987f3f7 Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Sun, 13 Feb 2022 20:04:52 +0100 Subject: [PATCH 5/8] add step "Clean up dangling images" --- .github/workflows/code-checks.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index a106208934591..1a0e0c3df5889 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -170,10 +170,13 @@ jobs: cancel-in-progress: true steps: + - name: Clean up dangling images + run: docker image prune -f + - name: Checkout uses: actions/checkout@v2 with: fetch-depth: 0 - - name: Build Docker Image + - name: Build image run: docker build --no-cache --tag pandas-dev-env . From 54e7490b1be30e08f3111ab1214b3e5a22588924 Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Sun, 13 Feb 2022 21:21:27 +0100 Subject: [PATCH 6/8] pin base image --- Dockerfile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Dockerfile b/Dockerfile index 34a13e69d73d2..1cbe06ac8739c 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM quay.io/condaforge/miniforge3 +FROM quay.io/condaforge/miniforge3:4.11.0-0 # if you forked pandas, you can pass in your own GitHub username to use your fork # i.e. gh_username=myname @@ -45,4 +45,4 @@ RUN . /opt/conda/etc/profile.d/conda.sh \ && cd "$pandas_home" \ && export \ && python setup.py build_ext -j 4 \ - && python -m pip install --no-build-isolation -e . + && python -m pip install --no-build-isolation -e . \ No newline at end of file From da0413a92bb0de793602fd7fb28968a759d58adf Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Tue, 15 Feb 2022 23:02:06 +0100 Subject: [PATCH 7/8] add newline at end of file --- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Dockerfile b/Dockerfile index 1cbe06ac8739c..2923cd60cc53b 100644 --- a/Dockerfile +++ b/Dockerfile @@ -45,4 +45,4 @@ RUN . /opt/conda/etc/profile.d/conda.sh \ && cd "$pandas_home" \ && export \ && python setup.py build_ext -j 4 \ - && python -m pip install --no-build-isolation -e . \ No newline at end of file + && python -m pip install --no-build-isolation -e . From 7edcf161b1338eff18a99ea12cc60ea25e133f2e Mon Sep 17 00:00:00 2001 From: Daniel Schmidt Date: Wed, 16 Feb 2022 08:06:49 +0100 Subject: [PATCH 8/8] always pull the latest version of the base image --- .github/workflows/code-checks.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/code-checks.yml b/.github/workflows/code-checks.yml index 1a0e0c3df5889..58bef05940af1 100644 --- a/.github/workflows/code-checks.yml +++ b/.github/workflows/code-checks.yml @@ -179,4 +179,4 @@ jobs: fetch-depth: 0 - name: Build image - run: docker build --no-cache --tag pandas-dev-env . + run: docker build --pull --no-cache --tag pandas-dev-env .