From db6131935044cc0c0972c22981c111c33825d585 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Tue, 8 Dec 2020 14:25:30 +0100 Subject: [PATCH 01/11] improved feature suggestion template --- .../ISSUE_TEMPLATE/---2-feature-request.md | 27 +++++++++++++------ 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/---2-feature-request.md b/.github/ISSUE_TEMPLATE/---2-feature-request.md index c2756fb952..a3e09142f1 100644 --- a/.github/ISSUE_TEMPLATE/---2-feature-request.md +++ b/.github/ISSUE_TEMPLATE/---2-feature-request.md @@ -7,14 +7,25 @@ assignees: '' --- -**Is your feature request related to a problem? Please describe.** -A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] +### New Feature / Enhancement Checklist + -**Describe the solution you'd like** -A clear and concise description of what you want to happen. +- [ ] I am not disclosing a [vulnerability](https://github.com/parse-community/parse-server/blob/master/SECURITY.md). +- [ ] I am not just asking a [question](https://github.com/parse-community/.github/blob/master/SUPPORT.md). +- [ ] I have searched through [existing issues](https://github.com/parse-community/parse-server/issues?q=is%3Aissue). +- [ ] I have a concept or discussed a concept in the [Parse Community Forum](https://community.parseplatform.org). -**Describe alternatives you've considered** -A clear and concise description of any alternative solutions or features you've considered. +### Current Limitation + -**Additional context** -Add any other context or screenshots about the feature request here. +### Feature / Enhancement Description + + +### Example Use Case + + +### Alternatives / Workarounds + + +### 3rd Party References + \ No newline at end of file From 3e2e5b47d27e42f7959d4da29238d98f95374f68 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Tue, 8 Dec 2020 21:00:15 +0100 Subject: [PATCH 02/11] added test case chapter to bug report template --- .github/ISSUE_TEMPLATE/---1-report-an-issue.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md index dbfa97106a..323c1341da 100644 --- a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md +++ b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md @@ -8,7 +8,7 @@ assignees: '' --- ### New Issue Checklist - + - [ ] I am not disclosing a [vulnerability](https://github.com/parse-community/parse-server/blob/master/SECURITY.md). - [ ] I am not just asking a [question](https://github.com/parse-community/.github/blob/master/SUPPORT.md). @@ -27,6 +27,16 @@ assignees: '' ### Expected Outcome +### Failing Test Case / PR + + +- [ ] 🤩 I submitted a PR with a fix and a test case. +- [ ] 🧐 I submitted a PR with a failing test case. + ### Environment From a820cee00e26c813c8f02901eb18035189103134 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Tue, 8 Dec 2020 21:04:49 +0100 Subject: [PATCH 03/11] PR wording --- .github/ISSUE_TEMPLATE/---1-report-an-issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md index 323c1341da..1d51d36729 100644 --- a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md +++ b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md @@ -27,7 +27,7 @@ assignees: '' ### Expected Outcome -### Failing Test Case / PR +### Failing Test Case / Pull Request (PR) + +- [ ] I am not disclosing a [vulnerability](https://github.com/parse-community/parse-server/blob/master/SECURITY.md). +- [ ] I create this PR in reference to an [issue](https://github.com/parse-community/parse-server/issues?q=is%3Aissue). + +### Issue Description + + +Related issue: #FILL_THIS_OUT + +### Approach + + +### TODOs before merging + + +- [ ] ... +- [ ] ... +- [ ] Add changes to docs (required) +- [ ] Add test cases (required) From d90c14248f8475d71e9bc5b3a57f8c9160be8af2 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Sat, 12 Dec 2020 12:48:45 +0100 Subject: [PATCH 05/11] improved formatting in issue template --- .github/ISSUE_TEMPLATE/---1-report-an-issue.md | 6 +++++- .github/ISSUE_TEMPLATE/---2-feature-request.md | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md index 1d51d36729..28b70a8509 100644 --- a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md +++ b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md @@ -8,7 +8,11 @@ assignees: '' --- ### New Issue Checklist - + - [ ] I am not disclosing a [vulnerability](https://github.com/parse-community/parse-server/blob/master/SECURITY.md). - [ ] I am not just asking a [question](https://github.com/parse-community/.github/blob/master/SUPPORT.md). diff --git a/.github/ISSUE_TEMPLATE/---2-feature-request.md b/.github/ISSUE_TEMPLATE/---2-feature-request.md index a3e09142f1..3527b1737d 100644 --- a/.github/ISSUE_TEMPLATE/---2-feature-request.md +++ b/.github/ISSUE_TEMPLATE/---2-feature-request.md @@ -8,7 +8,11 @@ assignees: '' --- ### New Feature / Enhancement Checklist - + - [ ] I am not disclosing a [vulnerability](https://github.com/parse-community/parse-server/blob/master/SECURITY.md). - [ ] I am not just asking a [question](https://github.com/parse-community/.github/blob/master/SUPPORT.md). From 339fafb0c22c9203f145a8cd0bafdd61367ab0e7 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Sat, 12 Dec 2020 12:49:08 +0100 Subject: [PATCH 06/11] removed checkbox for concept due to new GH discussions process --- .github/ISSUE_TEMPLATE/---2-feature-request.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/---2-feature-request.md b/.github/ISSUE_TEMPLATE/---2-feature-request.md index 3527b1737d..282e9e7a12 100644 --- a/.github/ISSUE_TEMPLATE/---2-feature-request.md +++ b/.github/ISSUE_TEMPLATE/---2-feature-request.md @@ -17,7 +17,6 @@ assignees: '' - [ ] I am not disclosing a [vulnerability](https://github.com/parse-community/parse-server/blob/master/SECURITY.md). - [ ] I am not just asking a [question](https://github.com/parse-community/.github/blob/master/SUPPORT.md). - [ ] I have searched through [existing issues](https://github.com/parse-community/parse-server/issues?q=is%3Aissue). -- [ ] I have a concept or discussed a concept in the [Parse Community Forum](https://community.parseplatform.org). ### Current Limitation From 9c4d63bb98152983967f9c30b7f8fd2b24794c42 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Sat, 12 Dec 2020 12:54:27 +0100 Subject: [PATCH 07/11] improved wording --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index b69438eb7e..c3e3a5ca39 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -21,5 +21,5 @@ Related issue: #FILL_THIS_OUT - [ ] ... - [ ] ... -- [ ] Add changes to docs (required) -- [ ] Add test cases (required) +- [ ] Add test cases +- [ ] Add changes to documentation From 9bcadcdb6a2bc697d18b364f26a7a3548b74c8f3 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Sat, 12 Dec 2020 13:10:11 +0100 Subject: [PATCH 08/11] improved PR todo list --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index c3e3a5ca39..53aa4ca937 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -11,7 +11,7 @@ ### Issue Description -Related issue: #FILL_THIS_OUT +Related issue: FILL_THIS_OUT ### Approach @@ -19,7 +19,7 @@ Related issue: #FILL_THIS_OUT ### TODOs before merging -- [ ] ... -- [ ] ... - [ ] Add test cases -- [ ] Add changes to documentation +- [ ] Add entry to changelog +- [ ] Add changes to documentation (guides, repository pages, in-code descriptions) +- [ ] ... \ No newline at end of file From c91d9fe7805512808abfc2f670c72ff0005934ff Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Sun, 13 Dec 2020 15:00:21 +0100 Subject: [PATCH 09/11] amended PR checklist; minor rewording --- .github/PULL_REQUEST_TEMPLATE/pull_request_template.md | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md index 53aa4ca937..006caff0b7 100644 --- a/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md +++ b/.github/PULL_REQUEST_TEMPLATE/pull_request_template.md @@ -6,7 +6,7 @@ --> - [ ] I am not disclosing a [vulnerability](https://github.com/parse-community/parse-server/blob/master/SECURITY.md). -- [ ] I create this PR in reference to an [issue](https://github.com/parse-community/parse-server/issues?q=is%3Aissue). +- [ ] I am creating this PR in reference to an [issue](https://github.com/parse-community/parse-server/issues?q=is%3Aissue). ### Issue Description @@ -17,9 +17,14 @@ Related issue: FILL_THIS_OUT ### TODOs before merging - + - [ ] Add test cases - [ ] Add entry to changelog - [ ] Add changes to documentation (guides, repository pages, in-code descriptions) +- [ ] Add security check warning +- [ ] Add new Parse Error codes to Parse JS SDK - [ ] ... \ No newline at end of file From 096b7edfacf0298533bf336b9c239a7a9dc55973 Mon Sep 17 00:00:00 2001 From: Manuel Trezza Date: Sun, 13 Dec 2020 15:04:56 +0100 Subject: [PATCH 10/11] removed duplicate wording --- .github/ISSUE_TEMPLATE/---1-report-an-issue.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md index 28b70a8509..44c2cc7f55 100644 --- a/.github/ISSUE_TEMPLATE/---1-report-an-issue.md +++ b/.github/ISSUE_TEMPLATE/---1-report-an-issue.md @@ -31,7 +31,7 @@ assignees: '' ### Expected Outcome -### Failing Test Case / Pull Request (PR) +### Failing Test Case / Pull Request +- [ ] Add [security check](https://github.com/parse-community/parse-server/blob/master/CONTRIBUTING.md#security-checks) - [ ] Add new Parse Error codes to Parse JS SDK - [ ] ... \ No newline at end of file diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bc7279af93..6c2ccd3bd8 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -100,7 +100,18 @@ If you want to make changes to [Parse Server Configuration][config] add the desi To view docs run `npm run docs` and check the `/out` directory. -### Code of Conduct +## Feature Considerations +### Security Checks + +The Parse Server security checks feature warns developers about weak security settings in their Parse Server deployment. + +A security check needs to be added for every new feature or enhancement that allows the developer to configure it in a way that weakens security mechanisms or exposes functionality which creates a weak spot for malicious attacks. If you are not sure whether your feature or enhancements requires a security check, feel free to ask. + +For example, allowing public read and write to a class may be useful to simplify development but should be disallowed in a production environment. + +Security checks are added in [SecurityChecks.js](https://github.com/parse-community/parse-server/blob/master/src/SecurityChecks.js). + +## Code of Conduct This project adheres to the [Contributor Covenant Code of Conduct](https://github.com/parse-community/parse-server/blob/master/CODE_OF_CONDUCT.md). By participating, you are expected to honor this code.