Add types where possible

Author: Jean85

src/BatchClient.php

@@ -52,7 +52,7 @@ public function sendRequest(RequestInterface $request): ResponseInterface
      *                        BatchResult with a map of request to result for success, request to
      *                        exception for failures
      */
-    public function sendRequests(array $requests)
+    public function sendRequests(array $requests): BatchResult
     {
         $batchResult = new BatchResult();
 

src/BatchResult.php

@@ -34,7 +34,7 @@ public function __construct()
      *
      * @return bool
      */
-    public function hasResponses()
+    public function hasResponses(): bool
     {
         return $this->responses->count() > 0;
     }
@@ -44,7 +44,7 @@ public function hasResponses()
      *
      * @return ResponseInterface[]
      */
-    public function getResponses()
+    public function getResponses(): array
     {
         $responses = [];
 
@@ -62,7 +62,7 @@ public function getResponses()
      *
      * @return bool
      */
-    public function isSuccessful(RequestInterface $request)
+    public function isSuccessful(RequestInterface $request): bool
     {
         return $this->responses->contains($request);
     }
@@ -76,7 +76,7 @@ public function isSuccessful(RequestInterface $request)
      *
      * @throws \UnexpectedValueException If request was not part of the batch or failed
      */
-    public function getResponseFor(RequestInterface $request)
+    public function getResponseFor(RequestInterface $request): ResponseInterface
     {
         try {
             return $this->responses[$request];
@@ -93,7 +93,7 @@ public function getResponseFor(RequestInterface $request)
      *
      * @return BatchResult the new BatchResult with this request-response pair added to it
      */
-    public function addResponse(RequestInterface $request, ResponseInterface $response)
+    public function addResponse(RequestInterface $request, ResponseInterface $response): BatchResult
     {
         $new = clone $this;
         $new->responses->attach($request, $response);
@@ -106,7 +106,7 @@ public function addResponse(RequestInterface $request, ResponseInterface $respon
      *
      * @return bool
      */
-    public function hasExceptions()
+    public function hasExceptions(): bool
     {
         return $this->exceptions->count() > 0;
     }
@@ -116,7 +116,7 @@ public function hasExceptions()
      *
      * @return Exception[]
      */
-    public function getExceptions()
+    public function getExceptions(): array
     {
         $exceptions = [];
 
@@ -134,7 +134,7 @@ public function getExceptions()
      *
      * @return bool
      */
-    public function isFailed(RequestInterface $request)
+    public function isFailed(RequestInterface $request): bool
     {
         return $this->exceptions->contains($request);
     }
@@ -148,7 +148,7 @@ public function isFailed(RequestInterface $request)
      *
      * @throws \UnexpectedValueException If request was not part of the batch or was successful
      */
-    public function getExceptionFor(RequestInterface $request)
+    public function getExceptionFor(RequestInterface $request): Exception
     {
         try {
             return $this->exceptions[$request];
@@ -165,7 +165,7 @@ public function getExceptionFor(RequestInterface $request)
      *
      * @return BatchResult the new BatchResult with this request-exception pair added to it
      */
-    public function addException(RequestInterface $request, Exception $exception)
+    public function addException(RequestInterface $request, Exception $exception): BatchResult
     {
         $new = clone $this;
         $new->exceptions->attach($request, $exception);

src/Deferred.php

@@ -34,7 +34,7 @@ public function __construct(callable $waitCallback)
     /**
      * {@inheritdoc}
      */
-    public function then(callable $onFulfilled = null, callable $onRejected = null)
+    public function then(callable $onFulfilled = null, callable $onRejected = null): Promise
     {
         $deferred = new self($this->waitCallback);
 
@@ -69,13 +69,15 @@ public function then(callable $onFulfilled = null, callable $onRejected = null)
     /**
      * {@inheritdoc}
      */
-    public function getState()
+    public function getState(): string
     {
         return $this->state;
     }
 
     /**
      * Resolve this deferred with a Response.
+     * 
+     * @param ResponseInterface $response
      */
     public function resolve(ResponseInterface $response)
     {
@@ -93,6 +95,8 @@ public function resolve(ResponseInterface $response)
 
     /**
      * Reject this deferred with an Exception.
+     * 
+     * @param Exception $exception
      */
     public function reject(Exception $exception)
     {

src/FlexibleHttpClient.php

@@ -4,6 +4,7 @@
 
 use Http\Client\HttpAsyncClient;
 use Http\Client\HttpClient;
+use Psr\Http\Client\ClientInterface;
 
 /**
  * A flexible http client, which implements both interface and will emulate

src/HttpAsyncClientDecorator.php

@@ -3,6 +3,7 @@
 namespace Http\Client\Common;
 
 use Http\Client\HttpAsyncClient;
+use Http\Promise\Promise;
 use Psr\Http\Message\RequestInterface;
 
 /**

src/HttpClientPool.php

@@ -40,7 +40,7 @@ public function addHttpClient($client)
      *
      * @return HttpClientPoolItem Return a http client that can do both sync or async
      */
-    abstract protected function chooseHttpClient();
+    abstract protected function chooseHttpClient(): HttpClientPoolItem;
 
     /**
      * {@inheritdoc}

src/HttpClientPool/LeastUsedClientPool.php

@@ -18,7 +18,7 @@ final class LeastUsedClientPool extends HttpClientPool
     /**
      * {@inheritdoc}
      */
-    protected function chooseHttpClient()
+    protected function chooseHttpClient(): HttpClientPoolItem
     {
         $clientPool = array_filter($this->clientPool, function (HttpClientPoolItem $clientPoolItem) {
             return !$clientPoolItem->isDisabled();

src/HttpClientPool/RandomClientPool.php

@@ -16,7 +16,7 @@ final class RandomClientPool extends HttpClientPool
     /**
      * {@inheritdoc}
      */
-    protected function chooseHttpClient()
+    protected function chooseHttpClient(): HttpClientPoolItem
     {
         $clientPool = array_filter($this->clientPool, function (HttpClientPoolItem $clientPoolItem) {
             return !$clientPoolItem->isDisabled();

src/HttpClientPool/RoundRobinClientPool.php

@@ -15,7 +15,7 @@ final class RoundRobinClientPool extends HttpClientPool
     /**
      * {@inheritdoc}
      */
-    protected function chooseHttpClient()
+    protected function chooseHttpClient(): HttpClientPoolItem
     {
         $last = current($this->clientPool);
 

src/HttpClientRouter.php

@@ -62,7 +62,7 @@ public function addClient($client, RequestMatcher $requestMatcher)
      *
      * @return HttpClient|HttpAsyncClient
      */
-    protected function chooseHttpClient(RequestInterface $request)
+    private function chooseHttpClient(RequestInterface $request)
     {
         foreach ($this->clients as $client) {
             if ($client['matcher']->matches($request)) {