Use class_exists to deal with next events class

Author: Olivier Dolbeau

EventListener/AutoAddMissingTranslations.php

@@ -41,15 +41,8 @@ public function __construct(StorageService $storage, DataCollectorTranslator $tr
         $this->storage = $storage;
     }
 
-    public function onTerminate($event): void
+    public function onTerminate(TerminateEvent $event): void
     {
-        // FilterResponseEvent have been renamed into ResponseEvent in sf 4.3
-        // Use this class to type hint event & remove the following condition once sf ^4.3 become the minimum supported version.
-        // @see https://github.com/symfony/symfony/blob/master/UPGRADE-4.3.md#httpkernel
-        if (!$event instanceof PostResponseEvent && !$event instanceof TerminateEvent) {
-            throw new \InvalidArgumentException('Unknown given event.');
-        }
-
         if (null === $this->dataCollector) {
             return;
         }
@@ -63,3 +56,10 @@ public function onTerminate($event): void
         }
     }
 }
+
+// FilterResponseEvent have been renamed into ResponseEvent in sf 4.3
+// @see https://github.com/symfony/symfony/blob/master/UPGRADE-4.3.md#httpkernel
+// To be removed once sf ^4.3 become the minimum supported version.
+if (!\class_exists(TerminateEvent::class) && \class_exists(FilterResponseEvent::class)) {
+    \class_alias(FilterResponseEvent::class, TerminateEvent::class);
+}

EventListener/EditInPlaceResponseListener.php

@@ -75,15 +75,8 @@ public function __construct(ActivatorInterface $activator, UrlGeneratorInterface
         $this->showUntranslatable = $showUntranslatable;
     }
 
-    public function onKernelResponse($event): void
+    public function onKernelResponse(ResponseEvent $event): void
     {
-        // FilterResponseEvent have been renamed into ResponseEvent in sf 4.3
-        // Use this class to type hint event & remove the following condition once sf ^4.3 become the minimum supported version.
-        // @see https://github.com/symfony/symfony/blob/master/UPGRADE-4.3.md#httpkernel
-        if (!$event instanceof FilterResponseEvent && !$event instanceof ResponseEvent) {
-            throw new \InvalidArgumentException('Unknown given event.');
-        }
-
         $request = $event->getRequest();
 
         if (!$this->activator->checkRequest($request)) {
@@ -135,3 +128,10 @@ public function onKernelResponse($event): void
         $event->getResponse()->setContent($content);
     }
 }
+
+// FilterResponseEvent have been renamed into ResponseEvent in sf 4.3
+// @see https://github.com/symfony/symfony/blob/master/UPGRADE-4.3.md#httpkernel
+// To be removed once sf ^4.3 become the minimum supported version.
+if (!\class_exists(ResponseEvent::class) && \class_exists(FilterResponseEvent::class)) {
+    \class_alias(FilterResponseEvent::class, ResponseEvent::class);
+}

phpstan-baseline.neon

@@ -76,25 +76,15 @@ parameters:
             path: DependencyInjection/TranslationExtension.php
 
         -
-            message: "#^Class Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\PostResponseEvent not found\\.$#"
-            count: 1
+            message: "#^Class Translation\\\\Bundle\\\\EventListener\\\\FilterResponseEvent not found\\.$#"
+            count: 2
             path: EventListener/AutoAddMissingTranslations.php
 
         -
             message: "#^Class Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\FilterResponseEvent not found\\.$#"
-            count: 1
-            path: EventListener/EditInPlaceResponseListener.php
-
-        -
-            message: "#^Call to method getRequest\\(\\) on an unknown class Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\FilterResponseEvent\\.$#"
             count: 2
             path: EventListener/EditInPlaceResponseListener.php
 
-        -
-            message: "#^Call to method getResponse\\(\\) on an unknown class Symfony\\\\Component\\\\HttpKernel\\\\Event\\\\FilterResponseEvent\\.$#"
-            count: 3
-            path: EventListener/EditInPlaceResponseListener.php
-
         -
             message: "#^Class Symfony\\\\Component\\\\Translation\\\\TranslatorInterface not found\\.$#"
             count: 1