From 1b80b0b82fa693155f0d8a64834f23ef8e601583 Mon Sep 17 00:00:00 2001 From: Olivier Dolbeau Date: Mon, 30 Dec 2019 13:07:59 +0100 Subject: [PATCH 1/3] Update docker image used in github actions --- .github/workflows/static.yml | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml index 14900316..505db179 100644 --- a/.github/workflows/static.yml +++ b/.github/workflows/static.yml @@ -1,22 +1,22 @@ -on: [push, pull_request] -name: Static analysis +name: Static code analysis + +on: [pull_request] + jobs: phpstan: - name: PHPStan runs-on: ubuntu-latest steps: - uses: actions/checkout@master - - name: PHPStan - uses: docker://oskarstark/phpstan-ga + - name: Run PHPStan + uses: docker://jakzal/phpqa:php7.3-alpine with: - args: analyze --no-progress + args: phpstan analyze php-cs-fixer: - name: PHP-CS-Fixer runs-on: ubuntu-latest steps: - uses: actions/checkout@master - - name: PHP-CS-Fixer - uses: docker://oskarstark/php-cs-fixer-ga + - name: Run PHP-CS-Fixer + uses: docker://jakzal/phpqa:php7.3-alpine with: - args: --dry-run --diff-format udiff + args: php-cs-fixer fix --dry-run --diff-format udiff -vvv From e2e026370d635fd133f85637cfb47fb87d212dad Mon Sep 17 00:00:00 2001 From: Richard van Laak Date: Mon, 30 Dec 2019 13:52:07 +0100 Subject: [PATCH 2/3] Update phpstan-baseline.neon --- phpstan-baseline.neon | 5 ----- 1 file changed, 5 deletions(-) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index a8f8fdcd..f36a783f 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -149,8 +149,3 @@ parameters: message: "#^Call to an undefined method Symfony\\\\Component\\\\Translation\\\\TranslatorBagInterface\\|Symfony\\\\Contracts\\\\Translation\\\\TranslatorInterface\\:\\:transChoice\\(\\)\\.$#" count: 2 path: Twig/TranslationExtension.php - - - - message: "#^Call to method getValue\\(\\) on an unknown class Symfony\\\\Component\\\\Translation\\\\DataCollector\\\\Data\\.$#" - count: 1 - path: Controller/SymfonyProfilerController.php From 1b439370818c8dbe51b4d75331bd08b210633d08 Mon Sep 17 00:00:00 2001 From: Olivier Dolbeau Date: Thu, 2 Jan 2020 09:39:33 +0100 Subject: [PATCH 3/3] Correct action names --- .github/workflows/static.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml index 505db179..2480e638 100644 --- a/.github/workflows/static.yml +++ b/.github/workflows/static.yml @@ -4,6 +4,7 @@ on: [pull_request] jobs: phpstan: + name: PHPStan runs-on: ubuntu-latest steps: - uses: actions/checkout@master @@ -13,6 +14,7 @@ jobs: args: phpstan analyze php-cs-fixer: + name: PHP-CS-Fixer runs-on: ubuntu-latest steps: - uses: actions/checkout@master