Make ReflectionGenerator final

nikic · nikic · commit b3ea6ce720b3 · 2020-07-21T11:53:00.000+02:00
This class is not safe against malicious extension / instantiation.
diff --git a/ext/reflection/php_reflection.c b/ext/reflection/php_reflection.c
@@ -6506,6 +6506,7 @@ PHP_MINIT_FUNCTION(reflection) /* {{{ */
 	INIT_CLASS_ENTRY(_reflection_entry, "ReflectionGenerator", class_ReflectionGenerator_methods);
 	reflection_init_class_handlers(&_reflection_entry);
 	reflection_generator_ptr = zend_register_internal_class(&_reflection_entry);
+	reflection_generator_ptr->ce_flags |= ZEND_ACC_FINAL;
 
 	INIT_CLASS_ENTRY(_reflection_entry, "ReflectionParameter", class_ReflectionParameter_methods);
 	reflection_init_class_handlers(&_reflection_entry);
diff --git a/ext/reflection/php_reflection.stub.php b/ext/reflection/php_reflection.stub.php
@@ -123,7 +123,7 @@ public function invokeArgs(array $args) {}
     public function getClosure() {}
 }
 
-class ReflectionGenerator
+final class ReflectionGenerator
 {
     public function __construct(Generator $generator) {}
 
diff --git a/ext/reflection/php_reflection_arginfo.h b/ext/reflection/php_reflection_arginfo.h
@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 762e9bab89b8edae0b567c1c3926ffa226abe874 */
+ * Stub hash: 330900e4fdcc9691ef971a270d065f859cee47bd */
 
 ZEND_BEGIN_ARG_INFO_EX(arginfo_class_Reflection_getModifierNames, 0, 0, 1)
 	ZEND_ARG_TYPE_INFO(0, modifiers, IS_LONG, 0)

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ public function invokeArgs(array $args) {}`
`123`	`123`	`public function getClosure() {}`
`124`	`124`	`}`
`125`	`125`
`126`		`-class ReflectionGenerator`
	`126`	`+final class ReflectionGenerator`
`127`	`127`	`{`
`128`	`128`	`public function __construct(Generator $generator) {}`
`129`	`129`