From c54dad84354e392e451a0850e0ac353da7a15314 Mon Sep 17 00:00:00 2001
From: David Carlier <devnexen@gmail.com>
Date: Fri, 16 Feb 2024 17:12:43 +0000
Subject: [PATCH] ext/ldap: few new unit tests (tls13 protocol).

---
 ...dap_set_option_tls_protocol_max_basic.phpt |  3 --
 ...t_option_tls_protocol_max_basic_tls13.phpt | 45 +++++++++++++++++++
 ...dap_set_option_tls_protocol_min_basic.phpt |  3 --
 ...t_option_tls_protocol_min_basic_tls13.phpt | 45 +++++++++++++++++++
 4 files changed, 90 insertions(+), 6 deletions(-)
 create mode 100644 ext/ldap/tests/ldap_set_option_tls_protocol_max_basic_tls13.phpt
 create mode 100644 ext/ldap/tests/ldap_set_option_tls_protocol_min_basic_tls13.phpt

diff --git a/ext/ldap/tests/ldap_set_option_tls_protocol_max_basic.phpt b/ext/ldap/tests/ldap_set_option_tls_protocol_max_basic.phpt
index 7fc24684c8f14..1b4ea8e9a11fd 100644
--- a/ext/ldap/tests/ldap_set_option_tls_protocol_max_basic.phpt
+++ b/ext/ldap/tests/ldap_set_option_tls_protocol_max_basic.phpt
@@ -15,7 +15,6 @@ foreach([
     LDAP_OPT_X_TLS_PROTOCOL_TLS1_0,
     LDAP_OPT_X_TLS_PROTOCOL_TLS1_1,
     LDAP_OPT_X_TLS_PROTOCOL_TLS1_2,
-    LDAP_OPT_X_TLS_PROTOCOL_TLS1_3,
 ] as $option) {
     $result = ldap_set_option($link, LDAP_OPT_X_TLS_PROTOCOL_MAX, $option);
     var_dump($result);
@@ -35,5 +34,3 @@ bool(true)
 int(770)
 bool(true)
 int(771)
-bool(true)
-int(772)
diff --git a/ext/ldap/tests/ldap_set_option_tls_protocol_max_basic_tls13.phpt b/ext/ldap/tests/ldap_set_option_tls_protocol_max_basic_tls13.phpt
new file mode 100644
index 0000000000000..2f83b807c4a4d
--- /dev/null
+++ b/ext/ldap/tests/ldap_set_option_tls_protocol_max_basic_tls13.phpt
@@ -0,0 +1,45 @@
+--TEST--
+ldap_set_option() - Basic test for TLS protocol max ldap option
+--CREDITS--
+Chad Sikorra <Chad.Sikorra@gmail.com>
+--EXTENSIONS--
+ldap
+--SKIPIF--
+<?php
+
+if (!defined("LDAP_OPT_X_TLS_PROTOCOL_MAX")) {
+    die('LDAP_OPT_X_TLS_PROTOCOL_MAX unsupported.');
+}
+--FILE--
+<?php
+require "connect.inc";
+$link = ldap_connect($uri);
+
+foreach([
+    LDAP_OPT_X_TLS_PROTOCOL_SSL2,
+    LDAP_OPT_X_TLS_PROTOCOL_SSL3,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_0,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_1,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_2,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_3,
+] as $option) {
+    $result = ldap_set_option($link, LDAP_OPT_X_TLS_PROTOCOL_MAX, $option);
+    var_dump($result);
+
+    ldap_get_option($link, LDAP_OPT_X_TLS_PROTOCOL_MAX, $optionval);
+    var_dump($optionval);
+}
+?>
+--EXPECT--
+bool(true)
+int(512)
+bool(true)
+int(768)
+bool(true)
+int(769)
+bool(true)
+int(770)
+bool(true)
+int(771)
+bool(true)
+int(772)
diff --git a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt
index 5c4da7368b62d..44abaeb9d9a3b 100644
--- a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt
+++ b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic.phpt
@@ -15,7 +15,6 @@ foreach([
     LDAP_OPT_X_TLS_PROTOCOL_TLS1_0,
     LDAP_OPT_X_TLS_PROTOCOL_TLS1_1,
     LDAP_OPT_X_TLS_PROTOCOL_TLS1_2,
-    LDAP_OPT_X_TLS_PROTOCOL_TLS1_3,
 ] as $option) {
     $result = ldap_set_option($link, LDAP_OPT_X_TLS_PROTOCOL_MIN, $option);
     var_dump($result);
@@ -35,5 +34,3 @@ bool(true)
 int(770)
 bool(true)
 int(771)
-bool(true)
-int(772)
diff --git a/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic_tls13.phpt b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic_tls13.phpt
new file mode 100644
index 0000000000000..e2f2af8763bf0
--- /dev/null
+++ b/ext/ldap/tests/ldap_set_option_tls_protocol_min_basic_tls13.phpt
@@ -0,0 +1,45 @@
+--TEST--
+ldap_set_option() - Basic test for TLS protocol min ldap option
+--CREDITS--
+Chad Sikorra <Chad.Sikorra@gmail.com>
+--EXTENSIONS--
+ldap
+--SKIPIF--
+<?php
+
+if (!defined("LDAP_OPT_X_TLS_PROTOCOL_TLS1_3")) {
+    die('LDAP_OPT_X_TLS_PROTOCOL_TLS1_3 unsupported.');
+}
+--FILE--
+<?php
+require "connect.inc";
+$link = ldap_connect($uri);
+
+foreach([
+    LDAP_OPT_X_TLS_PROTOCOL_SSL2,
+    LDAP_OPT_X_TLS_PROTOCOL_SSL3,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_0,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_1,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_2,
+    LDAP_OPT_X_TLS_PROTOCOL_TLS1_3,
+] as $option) {
+    $result = ldap_set_option($link, LDAP_OPT_X_TLS_PROTOCOL_MIN, $option);
+    var_dump($result);
+
+    ldap_get_option($link, LDAP_OPT_X_TLS_PROTOCOL_MIN, $optionval);
+    var_dump($optionval);
+}
+?>
+--EXPECT--
+bool(true)
+int(512)
+bool(true)
+int(768)
+bool(true)
+int(769)
+bool(true)
+int(770)
+bool(true)
+int(771)
+bool(true)
+int(772)