Assume stored credentials are always valid when present

Author: Ry Anderson

packages/common/src/client/sync/stream/AbstractRemote.ts

@@ -20,8 +20,6 @@ export type RemoteConnector = {
 const POWERSYNC_TRAILING_SLASH_MATCH = /\/+$/;
 const POWERSYNC_JS_VERSION = PACKAGE.version;
 
-// Refresh at least 30 sec before it expires
-const REFRESH_CREDENTIALS_SAFETY_PERIOD_MS = 30_000;
 const SYNC_QUEUE_REQUEST_LOW_WATER = 5;
 
 // Keep alive message is sent every period
@@ -122,21 +120,11 @@ export abstract class AbstractRemote {
   }
 
   async getCredentials(): Promise<PowerSyncCredentials | null> {
-    const { expiresAt } = this.credentials ?? {};
-    const currentTime = new Date(new Date().valueOf() + REFRESH_CREDENTIALS_SAFETY_PERIOD_MS);
-    if (expiresAt && expiresAt > currentTime) {
+    // If we have credentials stored, return them.
+    if (this.credentials) {
       return this.credentials!;
     }
 
-    // Check if existing stored token is still valid
-    if (this.credentials?.token) {
-      const { exp } = this.parseToken(this.credentials?.token) ?? {};
-
-      if (exp && new Date(Number(exp) * 1000) > currentTime) {
-        return this.credentials!;
-      }
-    }
-
     this.credentials = await this.connector.fetchCredentials();
     if (this.credentials?.endpoint.match(POWERSYNC_TRAILING_SLASH_MATCH)) {
       throw new Error(
@@ -150,14 +138,6 @@ export abstract class AbstractRemote {
     return `powersync-js/${POWERSYNC_JS_VERSION}`;
   }
 
-  private parseToken(token: string) {
-    try {
-      return JSON.parse(Buffer.from(token.split('.')[1], 'base64').toString());
-    } catch (_) {
-      return null;
-    }
-  }
-
   protected async buildRequest(path: string) {
     const credentials = await this.getCredentials();
     if (credentials != null && (credentials.endpoint == null || credentials.endpoint == '')) {

packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts

@@ -296,6 +296,7 @@ The next upload iteration will be delayed.`);
               break;
             }
           } catch (ex) {
+            // TODO: Handle 401s to invalidate cached credentials
             checkedCrudItem = undefined;
             this.updateSyncStatus({
               dataFlow: {