Run pdk validate -a to resolve lint problems

Author: nathanlcarlson

spec/acceptance/compose_v3_spec.rb

@@ -33,7 +33,7 @@ class { 'docker::compose':
     end
   end
 
-  context 'Creating compose v3 projects', win_broken: true do
+  context 'Creating compose v3 projects', :win_broken do
     let(:install_pp) do
       <<-MANIFEST
         docker_compose { 'web':
@@ -59,7 +59,7 @@ class { 'docker::compose':
     end
   end
 
-  context 'creating compose projects with multi compose files', win_broken: true do
+  context 'creating compose projects with multi compose files', :win_broken do
     before(:all) do
       install_pp = <<-MANIFEST
         docker_compose { 'web1':
@@ -79,7 +79,7 @@ class { 'docker::compose':
     end
   end
 
-  context 'Destroying project with multiple compose files', win_broken: true do
+  context 'Destroying project with multiple compose files', :win_broken do
     let(:destroy_pp) do
       <<-MANIFEST
         docker_compose { 'web1':

spec/acceptance/docker_full_spec.rb

@@ -49,7 +49,7 @@
 end
 
 describe 'the Puppet Docker module' do
-  context 'clean up before each test', win_broken: true do
+  context 'clean up before each test', :win_broken do
     before(:each) do
       retry_on_error_matching(60, 5, %r{connection failure running}) do
         # Stop all container using systemd
@@ -70,7 +70,7 @@
     end
 
     describe 'docker class' do
-      context 'without any parameters', win_broken: true do
+      context 'without any parameters', :win_broken do
         let(:pp) { "class { 'docker': #{docker_args} }" }
 
         it 'runs successfully' do
@@ -349,7 +349,7 @@ class { 'docker': #{docker_args} }
         end
       end
 
-      it 'creates a new image based on a tar', win_broken: true do
+      it 'creates a new image based on a tar', :win_broken do
         pp = <<-EOS
           class { 'docker': #{docker_args} }
           docker::image { '#{default_image}':
@@ -585,7 +585,7 @@ class { 'docker': #{docker_args} }
 
       # cpuset is not supported on Docker Windows
       # STDERR: C:/Program Files/Docker/docker.exe: Error response from daemon: invalid option: Windows does not support CpusetCpus.
-      it 'starts a container with cpuset paramater set', win_broken: true do
+      it 'starts a container with cpuset paramater set', :win_broken do
         pp = <<-EOS
           class { 'docker': #{docker_args} }
 
@@ -614,7 +614,7 @@ class { 'docker': #{docker_args} }
       end
 
       # leagacy container linking was not implemented on Windows. --link is a legacy Docker feature: https://docs.docker.com/network/links/
-      it 'starts multiple linked containers', win_broken: true do
+      it 'starts multiple linked containers', :win_broken do
         pp = <<-EOS
           class { 'docker': #{docker_args} }
 
@@ -669,7 +669,7 @@ class { 'docker': #{docker_args} }
         end
       end
 
-      it 'stops a running container', win_broken: true do
+      it 'stops a running container', :win_broken do
         pp = <<-EOS
           class { 'docker': #{docker_args} }
 
@@ -860,7 +860,7 @@ class { 'docker': #{docker_args} }
     end
   end
 
-  describe 'docker::exec', win_broken: true do
+  describe 'docker::exec', :win_broken do
     it 'runs a command inside an already running container' do
       pp = <<-EOS
           class { 'docker': #{docker_args} }
@@ -919,7 +919,7 @@ class { 'docker': #{docker_args} }
       apply_manifest(pp_delete, catch_failures: true)
     end
 
-    it 'onlies run if notified when refreshonly is true', win_broken: true do
+    it 'onlies run if notified when refreshonly is true', :win_broken do
       container_name = 'container_4_2'
       pp = <<-EOS
           class { 'docker': #{docker_args} }

spec/acceptance/docker_spec.rb

@@ -293,7 +293,7 @@ class { 'docker': #{docker_args}}
       sleep 10
     end
 
-    it 'is able to login to the registry', retry: 3, retry_wait: 10, win_broken: true do
+    it 'is able to login to the registry', :win_broken, retry: 3, retry_wait: 10 do
       pp = <<-MANIFEST
         docker::registry { '#{registry_address}':
           username => 'username',
@@ -305,7 +305,7 @@ class { 'docker': #{docker_args}}
       run_shell("test -e \"#{root_dir}/registry-auth-puppet_receipt_#{server_strip}_root\"", expect_failures: false)
     end
 
-    it 'is able to logout from the registry', win_broken: true do
+    it 'is able to logout from the registry', :win_broken do
       pp = <<-MANIFEST
         docker::registry { '#{registry_address}':
           ensure=> absent,
@@ -315,7 +315,7 @@ class { 'docker': #{docker_args}}
       run_shell("grep #{registry_address} #{config_file}", expect_failures: true)
     end
 
-    it 'does not create receipt if registry login fails', win_broken: true do
+    it 'does not create receipt if registry login fails', :win_broken do
       pp = <<-MANIFEST
         docker::registry { '#{registry_bad_address}':
           username => 'username',

spec/acceptance/machine_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper_acceptance'
 
-describe 'docker::machine', win_broken: true do
+describe 'docker::machine', :win_broken do
   context 'with default parameters' do
     pp = <<-EOS
       include docker::machine

spec/acceptance/stack_spec.rb

@@ -12,7 +12,7 @@
   wait_for_container_seconds = 10
 end
 
-describe 'docker stack', win_broken: true do
+describe 'docker stack', :win_broken do
   before(:all) do
     retry_on_error_matching(60, 5, %r{connection failure running}) do
       install_pp = <<-MANIFEST

spec/classes/compose_spec.rb

@@ -9,7 +9,7 @@
   },
   'with version => 1.7.0' => {
     'version' => '1.7.0'
-  },
+  }
 }
 
 describe 'docker::compose', type: :class do
@@ -33,7 +33,7 @@
         context title do
           params = {
             'ensure' => 'present',
-            'version' => defaults['compose_version'],
+            'version' => defaults['compose_version']
           }.merge(local_params)
 
           let(:facts) do

spec/shared_examples/compose.rb

@@ -5,7 +5,7 @@
   version      = _params['version']
 
   if _params['manage_package']
-    ensure_value = 
+    ensure_value =
       if _params['version'] != :undef && _params['ensure'] != 'absent'
         _params['version']
       else
@@ -15,7 +15,7 @@
     case _facts['os']['family']
     when 'Debian', 'RedHat'
       it {
-        is_expected.to contain_package('docker-compose-plugin').with(
+        expect(subject).to contain_package('docker-compose-plugin').with(
           ensure: ensure_value,
         )
       }

spec/unit/lib/puppet/type/docker_compose_spec.rb

@@ -23,13 +23,13 @@
 
   it 'has expected properties' do
     properties.each do |property|
-      expect(compose.properties.map(&:name)).to be_include(property)
+      expect(compose.properties.map(&:name)).to include(property)
     end
   end
 
   it 'has expected parameters' do
     params.each do |param|
-      expect(compose.parameters).to be_include(param)
+      expect(compose.parameters).to include(param)
     end
   end
 

spec/unit/lib/puppet/type/docker_network_spec.rb

@@ -29,13 +29,13 @@
 
   it 'has expected properties' do
     properties.each do |property|
-      expect(network.properties.map(&:name)).to be_include(property)
+      expect(network.properties.map(&:name)).to include(property)
     end
   end
 
   it 'has expected parameters' do
     params.each do |param|
-      expect(network.parameters).to be_include(param)
+      expect(network.parameters).to include(param)
     end
   end
 end

spec/unit/lib/puppet/type/docker_stack_spec.rb

@@ -21,13 +21,13 @@
 
   it 'has expected properties' do
     properties.each do |property|
-      expect(stack.properties.map(&:name)).to be_include(property)
+      expect(stack.properties.map(&:name)).to include(property)
     end
   end
 
   it 'has expected parameters' do
     params.each do |param|
-      expect(stack.parameters).to be_include(param)
+      expect(stack.parameters).to include(param)
     end
   end
 

spec/unit/lib/puppet/type/docker_volume_spec.rb

@@ -22,13 +22,13 @@
 
   it 'has expected properties' do
     properties.each do |property|
-      expect(volume.properties.map(&:name)).to be_include(property)
+      expect(volume.properties.map(&:name)).to include(property)
     end
   end
 
   it 'has expected parameters' do
     params.each do |param|
-      expect(volume.parameters).to be_include(param)
+      expect(volume.parameters).to include(param)
     end
   end
 end