(SUP-2677) Deprecate backup functionality

elainemccloskey · elainemccloskey · commit 034d40da8211 · 2021-10-04T16:49:55.000+01:00
diff --git a/manifests/init.pp b/manifests/init.pp
@@ -49,7 +49,7 @@
         class { 'pe_databases::backup':
           disable_maintenance => ! $manage_database_backups,
         }
-        notify { 'pe_databases_backup__deprecate_warn':
+        notify { 'pe_databases_backup_deprecate_warn':
           message  => 'The backup functionality in the pe_databases module has been deprecated and will be removed in a future release',
           loglevel => warning,
         }
diff --git a/spec/acceptance/backup_spec.rb b/spec/acceptance/backup_spec.rb
@@ -8,7 +8,7 @@ class { 'pe_databases':
        }#{' '}
        MANIFEST
 
-    # Run it twice and test for idempotency
-    idempotent_apply(pp)
+    # Expect a change due to backup notify
+    apply_manifest(pp, expect_changes: true)
   end
 end

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@`
`49`	`49`	`class { 'pe_databases::backup':`
`50`	`50`	`disable_maintenance => ! $manage_database_backups,`
`51`	`51`	`}`
`52`		`- notify { 'pe_databases_backup__deprecate_warn':`
	`52`	`+ notify { 'pe_databases_backup_deprecate_warn':`
`53`	`53`	`message => 'The backup functionality in the pe_databases module has been deprecated and will be removed in a future release',`
`54`	`54`	`loglevel => warning,`
`55`	`55`	`}`