(maint) addresses lint issues

Author: eputnam

manifests/server/service.pp

@@ -31,14 +31,14 @@
       # Without it, we may continue doing more work before the database is
       # prepared leading to a nasty race condition.
       postgresql_conn_validator{ 'validate_service_is_running':
-        run_as      => $user,
-        db_name     => $default_database,
-        port        => $port,
-        sleep       => 1,
-        tries       => 60,
-        psql_path   => $psql_path,
-        require     => Service['postgresqld'],
-        before      => Anchor['postgresql::server::service::end']
+        run_as    => $user,
+        db_name   => $default_database,
+        port      => $port,
+        sleep     => 1,
+        tries     => 60,
+        psql_path => $psql_path,
+        require   => Service['postgresqld'],
+        before    => Anchor['postgresql::server::service::end']
       }
       Postgresql::Server::Database <| title == $default_database |> -> Postgresql_conn_validator['validate_service_is_running']
     }

manifests/validate_db_connection.pp

@@ -18,7 +18,7 @@
   include postgresql::client
   include postgresql::params
 
-  warning("postgresql::validate_db_connection is deprecated, please use postgresql_conn_validator.")
+  warning('postgresql::validate_db_connection is deprecated, please use postgresql_conn_validator.')
 
   $psql_path = $postgresql::params::psql_path
   $module_workdir = $postgresql::params::module_workdir

spec/acceptance/db_spec.rb

@@ -22,7 +22,6 @@ class { 'postgresql::server':
       apply_manifest(pp, :catch_failures => true)
       apply_manifest(pp, :catch_changes => true)
 
-
       # Verify that the postgres password works
       shell("echo 'localhost:*:*:postgres:\'space password\'' > /root/.pgpass")
       shell("chmod 600 /root/.pgpass")

spec/acceptance/postgresql_conn_validator_spec.rb

@@ -10,13 +10,13 @@ class { 'postgresql::server':
       password_hash => postgresql_password('testuser','test1'),
     }->
     postgresql::server::database { 'testdb':
-      owner => 'testuser',
+      owner   => 'testuser',
       require => Postgresql::Server::Role['testuser']
     }->
     postgresql::server::database_grant { 'allow connect for testuser':
       privilege => 'CONNECT',
-      db => 'testdb',
-      role => 'testuser',
+      db        => 'testdb',
+      role      => 'testuser',
     }
 
   EOS
@@ -28,11 +28,11 @@ class { 'postgresql::server':
       pp = <<-EOS
         #{install_pp}->
         postgresql_conn_validator { 'validate this':
-          db_name => 'testdb',
+          db_name     => 'testdb',
           db_username => 'testuser',
           db_password => 'test1',
-          host => 'localhost',
-          psql_path => '/usr/bin/psql',
+          host        => 'localhost',
+          psql_path   => '/usr/bin/psql',
         }
     EOS
 
@@ -65,7 +65,7 @@ class { 'postgresql::server':
         #{install_pp}->
         postgresql_conn_validator { 'validate this':
           psql_path => '/usr/bin/psql',
-          tries => 3
+          tries     => 3
         }
      EOS
 

spec/unit/puppet/provider/postgresql_conn_validator/ruby_spec.rb

@@ -9,9 +9,9 @@
 
   let(:attributes) do
     {
-      :psql_path => '/usr/bin/psql',
-      :host => 'db.test.com',
-      :port => '4444',
+      :psql_path   => '/usr/bin/psql',
+      :host        => 'db.test.com',
+      :port        => '4444',
       :db_username => 'testuser',
       :db_password => 'testpass'
     }
@@ -37,8 +37,8 @@
       {
         :connect_settings => {
           :PGPASSWORD => 'testpass',
-          :PGHOST => 'db.test.com',
-          :PGPORT => '1234'
+          :PGHOST     => 'db.test.com',
+          :PGPORT     => '1234'
         }
       }
     end