Make the app fixture callable with default oauth security engine

Author: ArtyomVancyan

tests/conftest.py

@@ -38,43 +38,49 @@ def backends():
 
 
 @pytest.fixture
-def app():
-    oauth2 = OAuth2()
-    application = FastAPI()
-    app_router = APIRouter()
+def get_app():
+    def fixture_wrapper(authentication: OAuth2 = None):
+        if not authentication:
+            authentication = OAuth2()
 
-    @app_router.get("/user")
-    def user(request: Request, _: str = Depends(oauth2)):
-        return request.user
+        oauth2 = authentication
+        application = FastAPI()
+        app_router = APIRouter()
 
-    @app_router.get("/auth")
-    def auth(request: Request):
-        access_token = request.auth.jwt_create({
-            "name": "test",
-            "sub": "test",
-            "id": "test",
+        @app_router.get("/user")
+        def user(request: Request, _: str = Depends(oauth2)):
+            return request.user
+
+        @app_router.get("/auth")
+        def auth(request: Request):
+            access_token = request.auth.jwt_create({
+                "name": "test",
+                "sub": "test",
+                "id": "test",
+            })
+            response = Response()
+            response.set_cookie(
+                "Authorization",
+                value=f"Bearer {access_token}",
+                max_age=request.auth.expires,
+                expires=request.auth.expires,
+                httponly=request.auth.http,
+            )
+            return response
+
+        application.include_router(app_router)
+        application.include_router(oauth2_router)
+        application.add_middleware(OAuth2Middleware, config={
+            "allow_http": True,
+            "clients": [
+                OAuth2Client(
+                    backend=GithubOAuth2,
+                    client_id="test_id",
+                    client_secret="test_secret",
+                ),
+            ],
         })
-        response = Response()
-        response.set_cookie(
-            "Authorization",
-            value=f"Bearer {access_token}",
-            max_age=request.auth.expires,
-            expires=request.auth.expires,
-            httponly=request.auth.http,
-        )
-        return response
 
-    application.include_router(app_router)
-    application.include_router(oauth2_router)
-    application.add_middleware(OAuth2Middleware, config={
-        "allow_http": True,
-        "clients": [
-            OAuth2Client(
-                backend=GithubOAuth2,
-                client_id="test_id",
-                client_secret="test_secret",
-            ),
-        ],
-    })
+        return application
 
-    return application
+    return fixture_wrapper

tests/test_middleware.py

@@ -3,8 +3,8 @@
 
 
 @pytest.mark.anyio
-async def test_authentication(app):
-    async with AsyncClient(app=app, base_url="http://test") as client:
+async def test_middleware_on_authentication(get_app):
+    async with AsyncClient(app=get_app(), base_url="http://test") as client:
         response = await client.get("/user")
         assert response.status_code == 403  # Forbidden
 
@@ -15,8 +15,8 @@ async def test_authentication(app):
 
 
 @pytest.mark.anyio
-async def test_logout(app):
-    async with AsyncClient(app=app, base_url="http://test") as client:
+async def test_middleware_on_logout(get_app):
+    async with AsyncClient(app=get_app(), base_url="http://test") as client:
         await client.get("/auth")  # Simulate login
 
         response = await client.get("/user")

tests/test_routes.py

@@ -3,15 +3,15 @@
 
 
 @pytest.mark.anyio
-async def test_auth_redirect(app):
-    async with AsyncClient(app=app, base_url="http://test") as client:
+async def test_auth_redirect(get_app):
+    async with AsyncClient(app=get_app(), base_url="http://test") as client:
         response = await client.get("/oauth2/github/auth")
         assert response.status_code == 303  # Redirect
 
 
 @pytest.mark.anyio
-async def test_token_redirect(app):
-    async with AsyncClient(app=app, base_url="http://test") as client:
+async def test_token_redirect(get_app):
+    async with AsyncClient(app=get_app(), base_url="http://test") as client:
         response = await client.get("/oauth2/github/token")
         assert response.status_code == 400  # Bad Request
 
@@ -20,7 +20,7 @@ async def test_token_redirect(app):
 
 
 @pytest.mark.anyio
-async def test_logout_redirect(app):
-    async with AsyncClient(app=app, base_url="http://test") as client:
+async def test_logout_redirect(get_app):
+    async with AsyncClient(app=get_app(), base_url="http://test") as client:
         response = await client.get("/oauth2/logout")
         assert response.status_code == 307  # Redirect