Skip to content

Commit 0c8df1f

Browse files
author
Erlend E. Aasland
committed
Address review: visit members in correct order
1 parent a15b49f commit 0c8df1f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Modules/_functoolsmodule.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -160,11 +160,11 @@ partial_clear(partialobject *pto)
160160
static int
161161
partial_traverse(partialobject *pto, visitproc visit, void *arg)
162162
{
163+
Py_VISIT(Py_TYPE(pto));
163164
Py_VISIT(pto->fn);
164165
Py_VISIT(pto->args);
165166
Py_VISIT(pto->kw);
166167
Py_VISIT(pto->dict);
167-
Py_VISIT(Py_TYPE(pto));
168168
return 0;
169169
}
170170

@@ -524,9 +524,9 @@ keyobject_dealloc(keyobject *ko)
524524
static int
525525
keyobject_traverse(keyobject *ko, visitproc visit, void *arg)
526526
{
527+
Py_VISIT(Py_TYPE(ko));
527528
Py_VISIT(ko->cmp);
528529
Py_VISIT(ko->object);
529-
Py_VISIT(Py_TYPE(ko));
530530
return 0;
531531
}
532532

@@ -1341,6 +1341,7 @@ lru_cache_deepcopy(PyObject *self, PyObject *unused)
13411341
static int
13421342
lru_cache_tp_traverse(lru_cache_object *self, visitproc visit, void *arg)
13431343
{
1344+
Py_VISIT(Py_TYPE(self));
13441345
lru_list_elem *link = self->root.next;
13451346
while (link != &self->root) {
13461347
lru_list_elem *next = link->next;
@@ -1349,13 +1350,12 @@ lru_cache_tp_traverse(lru_cache_object *self, visitproc visit, void *arg)
13491350
Py_VISIT(Py_TYPE(link));
13501351
link = next;
13511352
}
1352-
Py_VISIT(self->func);
13531353
Py_VISIT(self->cache);
1354+
Py_VISIT(self->func);
13541355
Py_VISIT(self->kwd_mark);
13551356
Py_VISIT(self->lru_list_elem_type);
13561357
Py_VISIT(self->cache_info_type);
13571358
Py_VISIT(self->dict);
1358-
Py_VISIT(Py_TYPE(self));
13591359
return 0;
13601360
}
13611361

0 commit comments

Comments
 (0)