From bf7a7fc5f60510f33b97608466884cecde88b6d5 Mon Sep 17 00:00:00 2001 From: Burkov Egor Date: Mon, 27 Jan 2025 15:25:20 +0300 Subject: [PATCH 1/4] gh-129345: null check for indent syslogmodule --- Modules/syslogmodule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Modules/syslogmodule.c b/Modules/syslogmodule.c index adbd2fcc6ed74d..aa1bc9da91dfb9 100644 --- a/Modules/syslogmodule.c +++ b/Modules/syslogmodule.c @@ -176,7 +176,7 @@ syslog_openlog_impl(PyObject *module, PyObject *ident, long logopt, } } if (PySys_Audit("syslog.openlog", "Oll", ident ? ident : Py_None, logopt, facility) < 0) { - Py_DECREF(ident); + Py_XDECREF(ident); return NULL; } From 6c721cb4b0fa07e05a48b579e03a6160dfc57cdd Mon Sep 17 00:00:00 2001 From: "blurb-it[bot]" <43283697+blurb-it[bot]@users.noreply.github.com> Date: Tue, 28 Jan 2025 06:24:00 +0000 Subject: [PATCH 2/4] =?UTF-8?q?=F0=9F=93=9C=F0=9F=A4=96=20Added=20by=20blu?= =?UTF-8?q?rb=5Fit.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst new file mode 100644 index 00000000000000..55c0f73da385fa --- /dev/null +++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst @@ -0,0 +1 @@ +In `syslog.openlog` handle null pointer dereference when no `ident`, but have audit hook From 834fda544d69787840e6ce2e5f970af4d515a6d0 Mon Sep 17 00:00:00 2001 From: Burkov Egor Date: Tue, 28 Jan 2025 09:25:08 +0300 Subject: [PATCH 3/4] Update 2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst --- .../2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst index 55c0f73da385fa..d6052e1aa94445 100644 --- a/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst +++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst @@ -1 +1 @@ -In `syslog.openlog` handle null pointer dereference when no `ident`, but have audit hook +In `syslog.openlog` handle null pointer dereference when no `ident`, but have `audit` hook. From 8cdf5ca4c655b0ea927ca7f4321c3a46c4e57e04 Mon Sep 17 00:00:00 2001 From: Burkov Egor Date: Tue, 28 Jan 2025 13:59:14 +0300 Subject: [PATCH 4/4] Update Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst Co-authored-by: Tomas R. --- .../2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst index d6052e1aa94445..68e1103db45652 100644 --- a/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst +++ b/Misc/NEWS.d/next/Core_and_Builtins/2025-01-28-06-23-59.gh-issue-129345.uOjkML.rst @@ -1 +1 @@ -In `syslog.openlog` handle null pointer dereference when no `ident`, but have `audit` hook. +Fix null pointer dereference in :func:`syslog.openlog` when an audit hook raises an exception.