From 299d23f93d09ca184f2d7a07b607ccd4ea17196d Mon Sep 17 00:00:00 2001 From: Denis Osipov Date: Wed, 7 Jun 2017 12:41:24 +0500 Subject: [PATCH 1/3] Fix bpo-30584 --- Lib/test/test_os.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py index 746b3f8be8e0bf..733230566a43c9 100644 --- a/Lib/test/test_os.py +++ b/Lib/test/test_os.py @@ -472,7 +472,7 @@ def test_access_denied(self): # force CreateFile to fail with ERROR_ACCESS_DENIED. DETACHED_PROCESS = 8 subprocess.check_call( - ['icacls.exe', fname, '/deny', 'Users:(S)'], + ['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'], creationflags=DETACHED_PROCESS ) result = os.stat(fname) From 5ea73394cd49cf95a5fee6df4de9f82433a70d0a Mon Sep 17 00:00:00 2001 From: Denis Osipov Date: Wed, 7 Jun 2017 14:03:24 +0500 Subject: [PATCH 2/3] Adding a comment mentionning the bpo and explaining what is the identifier --- Lib/test/test_os.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Lib/test/test_os.py b/Lib/test/test_os.py index 733230566a43c9..4a21ff762dcaa1 100644 --- a/Lib/test/test_os.py +++ b/Lib/test/test_os.py @@ -472,6 +472,8 @@ def test_access_denied(self): # force CreateFile to fail with ERROR_ACCESS_DENIED. DETACHED_PROCESS = 8 subprocess.check_call( + # bpo-30584: Use security identifier *S-1-5-32-545 instead + # of localized "Users" to not depend on the locale. ['icacls.exe', fname, '/deny', '*S-1-5-32-545:(S)'], creationflags=DETACHED_PROCESS ) From f99207424615aee8d2736f29e27df2ef228bd5b1 Mon Sep 17 00:00:00 2001 From: Denis Osipov Date: Wed, 7 Jun 2017 21:11:31 +0500 Subject: [PATCH 3/3] Add Denis Osipov to Misc/ACKS --- Misc/ACKS | 1 + 1 file changed, 1 insertion(+) diff --git a/Misc/ACKS b/Misc/ACKS index 85d2fc65c47181..9b03c42a1e0465 100644 --- a/Misc/ACKS +++ b/Misc/ACKS @@ -1132,6 +1132,7 @@ William Orr Michele Orrù Tomáš Orsava Oleg Oshmyan +Denis Osipov Denis S. Otkidach Peter Otten Michael Otteneder