Skip to content

Commit df7f550

Browse files
committed
Reduce unnecessary header inclusions in models and io.
1 parent 7f0dffc commit df7f550

30 files changed

+26
-52
lines changed

examples/cpp/hello_world/main.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
#include <iostream>
2+
#include <torch/torch.h>
3+
#include <torchvision/vision.h>
24
#include <torchvision/models/resnet.h>
35

46
int main()

test/tracing/frcnn/test_frcnn_tracing.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#include <ATen/ATen.h>
21
#include <torch/script.h>
32
#include <torch/torch.h>
3+
#include <torchvision/vision.h>
44
#include <torchvision/ops/nms.h>
55

66
#ifdef _WIN32

torchvision/csrc/io/image/cpu/read_image_cpu.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "read_image_cpu.h"
2+
23
#include "readjpeg_cpu.h"
34
#include "readpng_cpu.h"
45

torchvision/csrc/io/image/cpu/read_image_cpu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/types.h>
44
#include "../image_read_mode.h"
55

66
C10_EXPORT torch::Tensor decode_image(

torchvision/csrc/io/image/cpu/read_write_file_cpu.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
#pragma once
22

3-
#include <errno.h>
43
#include <sys/stat.h>
5-
#include <torch/torch.h>
4+
#include <torch/types.h>
65

76
C10_EXPORT torch::Tensor read_file(const std::string& filename);
87

torchvision/csrc/io/image/cpu/readjpeg_cpu.cpp

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,12 @@
11
#include "readjpeg_cpu.h"
22

3-
#include <ATen/ATen.h>
4-
53
#if !JPEG_FOUND
64
torch::Tensor decodeJPEG(const torch::Tensor& data, ImageReadMode mode) {
75
TORCH_CHECK(
86
false, "decodeJPEG: torchvision not compiled with libjpeg support");
97
}
108
#else
11-
#include <jpeglib.h>
12-
#include <setjmp.h>
13-
#include "jpegcommon.h"
9+
#include "../jpegcommon.h"
1410

1511
struct torch_jpeg_mgr {
1612
struct jpeg_source_mgr pub;

torchvision/csrc/io/image/cpu/readjpeg_cpu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/types.h>
44
#include "../image_read_mode.h"
55

66
C10_EXPORT torch::Tensor decodeJPEG(

torchvision/csrc/io/image/cpu/readpng_cpu.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
#include "readpng_cpu.h"
22

3-
#include <ATen/ATen.h>
4-
53
#if !PNG_FOUND
64
torch::Tensor decodePNG(const torch::Tensor& data, ImageReadMode mode) {
75
TORCH_CHECK(false, "decodePNG: torchvision not compiled with libPNG support");

torchvision/csrc/io/image/cpu/readpng_cpu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/types.h>
44
#include "../image_read_mode.h"
55

66
C10_EXPORT torch::Tensor decodePNG(

torchvision/csrc/io/image/cpu/writejpeg_cpu.cpp

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
#include "writejpeg_cpu.h"
22

3-
#include <setjmp.h>
4-
#include <string>
5-
63
#if !JPEG_FOUND
74

85
torch::Tensor encodeJPEG(const torch::Tensor& data, int64_t quality) {
@@ -11,9 +8,7 @@ torch::Tensor encodeJPEG(const torch::Tensor& data, int64_t quality) {
118
}
129

1310
#else
14-
15-
#include <jpeglib.h>
16-
#include "jpegcommon.h"
11+
#include "../jpegcommon.h"
1712

1813
torch::Tensor encodeJPEG(const torch::Tensor& data, int64_t quality) {
1914
// Define compression structures and error handling
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/types.h>
44

55
C10_EXPORT torch::Tensor encodeJPEG(const torch::Tensor& data, int64_t quality);

torchvision/csrc/io/image/cpu/writepng_cpu.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,14 @@
11
#include "writejpeg_cpu.h"
22

3-
#include <setjmp.h>
4-
#include <string>
5-
63
#if !PNG_FOUND
74

85
torch::Tensor encodePNG(const torch::Tensor& data, int64_t compression_level) {
96
TORCH_CHECK(false, "encodePNG: torchvision not compiled with libpng support");
107
}
118

129
#else
13-
1410
#include <png.h>
11+
#include <setjmp.h>
1512

1613
struct torch_mem_encode {
1714
char* buffer;

torchvision/csrc/io/image/cpu/writepng_cpu.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/types.h>
44

55
C10_EXPORT torch::Tensor encodePNG(
66
const torch::Tensor& data,

torchvision/csrc/io/image/image.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
1-
21
#include "image.h"
3-
#include <ATen/ATen.h>
2+
43
#include <Python.h>
54

65
// If we are in a Windows environment, we need to define

torchvision/csrc/io/image/image.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
#pragma once
22

3-
// Comment
4-
#include <torch/script.h>
5-
#include <torch/torch.h>
63
#include "cpu/read_image_cpu.h"
74
#include "cpu/read_write_file_cpu.h"
85
#include "cpu/readjpeg_cpu.h"

torchvision/csrc/io/image/jpegcommon.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
1+
#if JPEG_FOUND
12
#include "jpegcommon.h"
2-
#include <string>
33

4-
#if JPEG_FOUND
54
void torch_jpeg_error_exit(j_common_ptr cinfo) {
65
/* cinfo->err really points to a torch_jpeg_error_mgr struct, so coerce
76
* pointer */

torchvision/csrc/io/image/jpegcommon.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#if JPEG_FOUND
99
#include <jpeglib.h>
1010
#include <setjmp.h>
11-
#include <string>
1211

1312
static const JOCTET EOI_BUFFER[1] = {JPEG_EOI};
1413
struct torch_jpeg_error_mgr {

torchvision/csrc/models/alexnet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/densenet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/googlenet.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
#include "googlenet.h"
22

3-
#include "modelsimpl.h"
4-
53
namespace vision {
64
namespace models {
75

torchvision/csrc/models/googlenet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/inception.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/mnasnet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/mobilenet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/modelsimpl.h

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
4-
5-
#ifndef TORCH_CHECK
6-
#define TORCH_CHECK AT_CHECK
7-
#endif
3+
#include <torch/nn.h>
84

95
namespace vision {
106
namespace models {

torchvision/csrc/models/resnet.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
#include "resnet.h"
22

3-
#include "modelsimpl.h"
4-
53
namespace vision {
64
namespace models {
75
namespace _resnetimpl {

torchvision/csrc/models/resnet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/shufflenetv2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/squeezenet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

torchvision/csrc/models/vgg.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#pragma once
22

3-
#include <torch/torch.h>
3+
#include <torch/nn.h>
44
#include "../macros.h"
55

66
namespace vision {

0 commit comments

Comments
 (0)