Add call. = FALSE to warning() calls

Author: Bisaloo

R/backport_linter.R

@@ -109,7 +109,10 @@ normalize_r_version <- function(r_version) {
     stop("`r_version` must be a R version number, returned by R_system_version(), or a string.", call. = FALSE)
   }
   if (r_version < "3.0.0") {
-    warning("It is not recommended to depend on an R version older than 3.0.0. Resetting 'r_version' to 3.0.0.")
+    warning(
+      "It is not recommended to depend on an R version older than 3.0.0. Resetting 'r_version' to 3.0.0.",
+      call. = FALSE
+    )
     r_version <- R_system_version("3.0.0")
   }
   r_version

R/cache.R

@@ -55,7 +55,8 @@ load_cache <- function(file, path = NULL) {
       error = function(e) {
         warning(
           "Could not load cache file '", file, "':\n",
-          conditionMessage(e)
+          conditionMessage(e),
+          call. = FALSE
         )
       }
     )

R/exclude.R

@@ -204,7 +204,8 @@ add_exclusions <- function(exclusions, lines, linters_string, exclude_linter_sep
         warning(
           "Could not find linter", if (length(bad) > 1L) "s" else "", " named ",
           glue_collapse(sQuote(bad), sep = ", ", last = " and "),
-          " in the list of active linters. Make sure the linter is uniquely identified by the given name or prefix."
+          " in the list of active linters. Make sure the linter is uniquely identified by the given name or prefix.",
+          call. = FALSE
         )
       }
       excluded_linters[matched] <- linter_names[idxs[matched]]

R/extract.R

@@ -51,7 +51,7 @@ get_knitr_pattern <- function(filename, lines) {
     ("knitr" %:::% "detect_pattern")(lines, tolower(("knitr" %:::% "file_ext")(filename))),
     warning = function(cond) {
       if (!grepl("invalid UTF-8", conditionMessage(cond), fixed = TRUE)) {
-        warning(cond)
+        warning(cond, call. = FALSE)
       }
       invokeRestart("muffleWarning")
     }

R/lint.R

@@ -238,7 +238,10 @@ lint_package <- function(path = ".", ...,
   pkg_path <- find_package(path)
 
   if (is.null(pkg_path)) {
-    warning(sprintf("Didn't find any R package searching upwards from '%s'.", normalizePath(path)))
+    warning(
+      sprintf("Didn't find any R package searching upwards from '%s'.", normalizePath(path)),
+      call. = FALSE
+    )
     return(NULL)
   }
 

R/linter_tags.R

@@ -121,7 +121,8 @@ validate_linter_db <- function(available, package) {
       "`linters.csv` must contain the columns 'linter' and 'tags'.\nPackage '",
       package, "' is missing ",
       paste0("'", setdiff(c("linter", "tags"), names(available)), "'", collapse = " and "),
-      "."
+      ".",
+      call. = FALSE
     )
     return(FALSE)
   }

R/object_usage_linter.R

@@ -215,7 +215,8 @@ parse_check_usage <- function(expression,
     # TODO (AshesITR): Remove this in the future, if no bugs arise from this safeguard
     warning(
       "Possible bug in lintr: Couldn't parse usage message ", sQuote(vals[is_missing][[1L]]), ". ",
-      "Ignoring ", sum(is_missing), " usage warnings. Please report an issue at https://github.com/r-lib/lintr/issues."
+      "Ignoring ", sum(is_missing), " usage warnings. Please report an issue at https://github.com/r-lib/lintr/issues.",
+      call. = FALSE
     )
   }
   # nocov end

R/settings.R

@@ -124,7 +124,8 @@ read_config_file <- function(config_file) {
           warning = function(w) {
             warning(
               "Warning from config setting '", setting, "' in '", format(conditionCall(w)), "':\n",
-              "    ", conditionMessage(w)
+              "    ", conditionMessage(w),
+              call. = FALSE
             )
             invokeRestart("muffleWarning")
           }
@@ -152,7 +153,10 @@ read_config_file <- function(config_file) {
 validate_config_file <- function(config, config_file, defaults) {
   matched <- names(config) %in% names(defaults)
   if (!all(matched)) {
-    warning("Found unused settings in config '", config_file, "': ", toString(names(config)[!matched]))
+    warning(
+      "Found unused settings in config '", config_file, "': ", toString(names(config)[!matched]),
+      call. = FALSE
+    )
   }
 
   validate_regex(config,

R/with.R

@@ -47,7 +47,8 @@ modify_defaults <- function(defaults, ...) {
     is_are <- if (length(bad_nms) > 1L) "are" else "is"
     warning(
       "Trying to remove ", glue_collapse(sQuote(bad_nms), sep = ", ", last = " and "),
-      ", which ", is_are, " not in `defaults`."
+      ", which ", is_are, " not in `defaults`.",
+      call. = FALSE
     )
   }
 
@@ -180,7 +181,8 @@ linters_with_defaults <- function(..., defaults = default_linters) {
   if (missing(defaults) && "default" %in% names(dots)) {
     warning(
       "'default' is not an argument to linters_with_defaults(). Did you mean 'defaults'? ",
-      "This warning will be removed when with_defaults() is fully deprecated."
+      "This warning will be removed when with_defaults() is fully deprecated.",
+      call. = FALSE
     )
     defaults <- dots$default
     nms <- names2(dots)

R/xml_nodes_to_lints.R

@@ -63,7 +63,7 @@ xml_nodes_to_lints <- function(xml, source_expression, lint_message,
   line1 <- xml_attr(xml, "line1")
   col1 <- xp_find_location(xml, range_start_xpath)
   if (is.na(col1)) {
-    warning("Could not find range start for lint. Defaulting to start of line.")
+    warning("Could not find range start for lint. Defaulting to start of line.", call. = FALSE)
     col1 <- 1L
   }
 
@@ -73,7 +73,7 @@ xml_nodes_to_lints <- function(xml, source_expression, lint_message,
   if (xml_attr(xml, "line2") == line1) {
     col2 <- xp_find_location(xml, range_end_xpath)
     if (is.na(col2)) {
-      warning("Could not find range end for lint. Defaulting to width 1.")
+      warning("Could not find range end for lint. Defaulting to width 1.", call. = FALSE)
       col2 <- col1
     }
   } else {
@@ -82,7 +82,7 @@ xml_nodes_to_lints <- function(xml, source_expression, lint_message,
 
   column_number <- xp_find_location(xml, column_number_xpath)
   if (is.na(column_number)) {
-    warning("Could not find location for lint. Defaulting to start of range.")
+    warning("Could not find location for lint. Defaulting to start of range.", call. = FALSE)
     column_number <- col1
   }