Merge 30dd346 into 9565050

Author: MichaelChirico

R/object_overwrite_linter.R

@@ -59,17 +59,21 @@ object_overwrite_linter <- function(
       stop("Package '", package, "' is not available.")
     }
   }
-  pkg_exports <- lapply(
-    packages,
-    # .__C__ etc.: drop 150+ "virtual" names since they are very unlikely to appear anyway
-    function(pkg) setdiff(grep("^[.]__[A-Z]__", getNamespaceExports(pkg), value = TRUE, invert = TRUE), allow_names)
-  )
+  pkg_exports <- lapply(packages, getNamespaceExports)
   pkg_exports <- data.frame(
     package = rep(packages, lengths(pkg_exports)),
     name = unlist(pkg_exports),
     stringsAsFactors = FALSE
   )
 
+  pkg_exports <- pkg_exports[
+    # .__C__ etc.: drop 150+ "virtual" names since they are very unlikely to appear anyway
+    !grepl("^[.]__[A-Z]__", pkg_exports$name) &
+      # exclude non-syntactic names. this might be supported upon user request.
+      make.names(pkg_exports$name) == pkg_exports$name &
+      !pkg_exports$name %in% allow_names,
+  ]
+
   # test that the symbol doesn't match an argument name in the function
   # NB: data.table := has parse token LEFT_ASSIGN as well
   xpath <- glue("