Skip to content

Commit bc78d68

Browse files
remove TODO (posted as issue comment)
1 parent c8483b7 commit bc78d68

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

tests/testthat/test-unnecessary_placeholder_linter.R

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,6 @@ test_that("unnecessary_placeholder_linter skips allowed usages", {
77
expect_lint("x %>% foo(., .)", NULL, unnecessary_placeholder_linter())
88
# . used as a keyword argument --> ok
99
expect_lint("x %>% foo(arg = .)", NULL, unnecessary_placeholder_linter())
10-
# TODO(chiricom): currently, the linter marks
11-
# ' x %>% ... %>% length(.) > 0
12-
# this _technically_ works as intended because it's parsed as
13-
# ' `>`(x %>% ... %>% length(), 0)
14-
# but I think the code is not quite behaving as intended.
15-
# ' x %>% ... %>% (length(.) > 0)
16-
# is probably closer to what was intended. So for now we mark the code as a
17-
# lint, but that also doesn't feel quite right (we're using this linter
18-
# as a signal of a different code quality issue).
1910
})
2011

2112
test_that("unnecessary_placeholder_linter blocks simple disallowed usages", {

0 commit comments

Comments
 (0)