Skip to content

Support non-syntactic names in object_overwrite_linter() #2346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AshesITR opened this issue Nov 23, 2023 · 0 comments · Fixed by #2347
Closed

Support non-syntactic names in object_overwrite_linter() #2346

AshesITR opened this issue Nov 23, 2023 · 0 comments · Fixed by #2347

Comments

@AshesITR
Copy link
Collaborator

This will be obsolete with #2344 I think, since I use get_r_string() there so overwrites of non-syntactic names should also be caught.

This reminds me that could use some tests.

Originally posted by @AshesITR in #2342 (comment)

MichaelChirico added a commit that referenced this issue Nov 24, 2023
…2347)

* fix detection of non-syntactic names in `object_overwrite_linter()`

fixes #2346

* fix non-syntactic string assignments

* actually fix it

* remove unnecessary startsWith() calls

* avoid escape

* move to separate test_that()

---------

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant