Support cudf-polars str.reverse
#19117
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon-b-miller
added
feature request
github-actions
bot
added
Python
mhaseeb123
approved these changes
Jun 7, 2025
davidwendt
reviewed
Jun 7, 2025
Comment on lines
+1
to
+13
| # Copyright (c) 2020-2025, NVIDIA CORPORATION. | ||
| from libc.stdint cimport int32_t | ||
| from libcpp.memory cimport unique_ptr | ||
| from libcpp.string cimport string | ||
| from pylibcudf.exception_handler cimport libcudf_exception_handler | ||
| from pylibcudf.libcudf.column.column cimport column | ||
| from pylibcudf.libcudf.column.column_view cimport column_view | ||
| from pylibcudf.libcudf.scalar.scalar cimport string_scalar | ||
| from pylibcudf.libcudf.types cimport size_type | ||
|
|
||
|
|
||
| cdef extern from "cudf/strings/reverse.hpp" namespace "cudf::strings" nogil: | ||
| cdef unique_ptr[column] reverse(column_view source_strings) |
There was a problem hiding this comment.
Suggested change
| # Copyright (c) 2020-2025, NVIDIA CORPORATION. | |
| from libc.stdint cimport int32_t | |
| from libcpp.memory cimport unique_ptr | |
| from libcpp.string cimport string | |
| from pylibcudf.exception_handler cimport libcudf_exception_handler | |
| from pylibcudf.libcudf.column.column cimport column | |
| from pylibcudf.libcudf.column.column_view cimport column_view | |
| from pylibcudf.libcudf.scalar.scalar cimport string_scalar | |
| from pylibcudf.libcudf.types cimport size_type | |
| cdef extern from "cudf/strings/reverse.hpp" namespace "cudf::strings" nogil: | |
| cdef unique_ptr[column] reverse(column_view source_strings) | |
| # Copyright (c) 2025, NVIDIA CORPORATION. | |
| from libcpp.memory cimport unique_ptr | |
| from pylibcudf.exception_handler cimport libcudf_exception_handler | |
| from pylibcudf.libcudf.column.column cimport column | |
| from pylibcudf.libcudf.column.column_view cimport column_view | |
| cdef extern from "cudf/strings/reverse.hpp" namespace "cudf::strings" nogil: | |
| cdef unique_ptr[column] reverse(column_view source_strings) except +libcudf_exception_handler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19025.
needs: pylibcudf tests, docs