Skip to content

feat(config): variables #35350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(config): variables #35350

wants to merge 13 commits into from

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Apr 13, 2025 •
edited
Loading

Changes

  • Implement self-hosted config option variables
  • Introduce a util/interpolator.ts to house the repeated logic between secrets and variables

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

@zharinov zharinov self-requested a review April 13, 2025 19:15
@RahulGautamSingh RahulGautamSingh mentioned this pull request Apr 13, 2025
Merged
6 tasks
viceice
viceice reviewed Apr 14, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to have the refactor in separate PR, otherwise lgtm

rarkins
rarkins requested changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create refactor PR first

@RahulGautamSingh RahulGautamSingh mentioned this pull request Apr 24, 2025
Merged
6 tasks
viceice
viceice reviewed May 13, 2025
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failed checks

@rarkins rarkins requested a review from viceice May 16, 2025 08:19
rarkins
rarkins reviewed May 16, 2025
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for keeping variables and secrets "apply" function separate?

viceice
viceice previously approved these changes May 16, 2025
View reviewed changes
@RahulGautamSingh
Copy link
Collaborator Author

What was the reason for keeping variables and secrets "apply" function separate?

No reason :)

@RahulGautamSingh RahulGautamSingh requested a review from rarkins May 16, 2025 15:27
@rarkins
Copy link
Collaborator

rarkins commented May 16, 2025

Is there any place where applying secrets and applying variables aren't done at the same time? If there's never any separation of them, these functions should be combined.

@RahulGautamSingh RahulGautamSingh requested review from viceice and rarkins and removed request for rarkins May 28, 2025 06:52
viceice
viceice reviewed Jun 4, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh requested a review from viceice June 4, 2025 23:22
viceice
viceice reviewed Jun 5, 2025
View reviewed changes
@RahulGautamSingh RahulGautamSingh requested a review from viceice June 7, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zharinov zharinov Awaiting requested review from zharinov

@rarkins rarkins Awaiting requested review from rarkins

@viceice viceice Awaiting requested review from viceice

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-masked "variables" object to complement "secrets"
3 participants
@RahulGautamSingh @rarkins @viceice