Skip to content

feat(Select): add bindings for select #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 28, 2021
Merged

feat(Select): add bindings for select #17

merged 2 commits into from
Sep 28, 2021

Conversation

tjbo
Copy link
Contributor

@tjbo tjbo commented Sep 22, 2021

This PR adds bindings for the select component.

@vercel
Copy link

vercel bot commented Sep 22, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @ri7nz on Vercel.

@ri7nz first needs to authorize it.

@tjbo
Copy link
Contributor Author

tjbo commented Sep 22, 2021

My auto formatter removed a couple of empty carriage returns in the readme.

Fyi, I've only been learning re-script less than a week; but will make more commits for chakra-ui components if this one is okay.

Cheers.

tjbo
tjbo commented Sep 22, 2021
View reviewed changes
r17x
r17x requested changes Sep 23, 2021
View reviewed changes
Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution. Keep learning and good job 👍

tjbo
tjbo commented Sep 28, 2021
View reviewed changes
src/Interfaces/Chakra__MakeProps.res
| #filled => "filled"->Identity.fromString
| #flushed => "flushed"->Identity.fromString
| #unstyled => "unstyled"->Identity.fromString
| #array(arr) => arr->arrayMap(identity)->Identity.fromArray
Copy link
Contributor Author

@tjbo tjbo Sep 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this array is for mobile sizes? But wasn't 100%, flagging it for you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This #array for support Responsive Style , see https://chakra-ui.com/docs/features/responsive-styles

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, just wanted to double check. I'll probably make more contributions soon as I'm working on something in Rescript and love Chakra.

Great to see someone already building this lib. Cheers.

tjbo
tjbo commented Sep 28, 2021
View reviewed changes
@r17x
Copy link
Collaborator

r17x commented Sep 28, 2021 •
edited
Loading

can you make it ammend for this commit (before I merge this commit) ? @tjbo

-- (fix): makeProps for select variant and size
++ feat(Select): fix makeProps for select variant and size

Cause using type: fix is for released code that's have been consumed to user.

@r17x r17x merged commit e7d31bd into rescript-ui:next Sep 28, 2021
r17x pushed a commit that referenced this pull request Sep 29, 2021
@tjbo @r17x
feat(Select): add bindings for select (#17)
26e9b43 
* feat(Select): add bindings for select

* (fix): makeProps for select variant and size
github-actions bot pushed a commit that referenced this pull request Sep 29, 2021
@semantic-release-bot
release(version): Release 1.2.0-next.7 [skip ci]
1d43efa 
# [1.2.0-next.7](v1.2.0-next.6...v1.2.0-next.7) (2021-09-29)

### Features

* **Select:** add bindings for select ([#17](#17)) ([26e9b43](26e9b43))
* **Select:** fix syntax ([ba061dd](ba061dd))
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
@anakmagang
chore(release): 1.2.0 [skip ci]
27d1986 
# [1.2.0](v1.1.0...v1.2.0) (2024-09-04)

### Bug Fixes

* **Components:** wrong type definition for ReactEvent.* ([87cc911](87cc911))
* **Input:** add value for Input ([#26](#26)) ([5cb98fc](5cb98fc))
* **Link:** missing anchor HTML element attributes ([3b4477d](3b4477d))
* **props:** fix invalid props for all Components ([1703258](1703258))
* **Select:** fix custom colors ([#22](#22)) ([8d9182e](8d9182e))

### Features

* **Fade, ScaleFade, Slide:** add component binding for Fade, ScaleFade, & Slide ([7b30d49](7b30d49))
* **Feedback:** add component binding for feedback ([#16](#16)) ([e68c2cb](e68c2cb))
* **Input:** add binding for Input ([#23](#23)) ([7cdf3f9](7cdf3f9))
* **Input:** add binding for Input extra ([#24](#24)) ([4a6e846](4a6e846))
* **Interfaces:** add binding for some HTML specification ([0b1040e](0b1040e))
* **MakeProps:** add sub-modules in MakeProps for handle object-fit, noOfLines, viewBox, and multi-type(string-or-number). ([51a1924](51a1924))
* **Media:** add bindin for Icon and Image Component ([762108e](762108e))
* **Media:** add binding component Avatar & AvatarGroup. ([a96e39e](a96e39e))
* **Navigation:** add binding for component navigation ([4428ec8](4428ec8))
* **Others:** add binding for Portal Component ([68e9679](68e9679))
* **Select:** add bindings for select ([#17](#17)) ([26e9b43](26e9b43))
* **Select:** fix syntax ([ba061dd](ba061dd))
* **Spacer:** add binding for Spacer component ([#25](#25)) ([e3ce148](e3ce148))
* support for rescript v11 ([#29](#29)) ([b87ffe5](b87ffe5))
* **Typography:** add binding for Heading and Text ([9f707a2](9f707a2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r17x r17x r17x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tjbo @r17x