Skip to content

Commit 1dd1c9d

Browse files
authored
Merge pull request #853 from Turbo87/mirage-factories
mirage: Move "links" into serializer
2 parents 8cc758e + ee76377 commit 1dd1c9d

File tree

7 files changed

+44
-206
lines changed

7 files changed

+44
-206
lines changed

mirage/factories/crate.js

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,6 @@ export default Factory.extend({
3030
_owner_teams: () => [],
3131
_owner_users: () => [],
3232

33-
links() {
34-
return {
35-
'owner_user': `/api/v1/crates/${this.id}/owner_user`,
36-
'owner_team': `/api/v1/crates/${this.id}/owner_team`,
37-
'reverse_dependencies': `/api/v1/crates/${this.id}/reverse_dependencies`,
38-
'version_downloads': `/api/v1/crates/${this.id}/downloads`,
39-
'versions': `/api/v1/crates/${this.id}/versions`,
40-
};
41-
},
42-
4333
withVersion: trait({
4434
afterCreate(crate, server) {
4535
server.create('version', { crate: crate.id });

mirage/factories/version.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,6 @@ export default Factory.extend({
2222
features: () => {},
2323
_authors: () => [],
2424

25-
links() {
26-
return {
27-
'authors': `/api/v1/crates/${this.crate}/${this.num}/authors`,
28-
'dependencies': `/api/v1/crates/${this.crate}/${this.num}/dependencies`,
29-
'version_downloads': `/api/v1/crates/${this.crate}/${this.num}/downloads`,
30-
};
31-
},
32-
3325
afterCreate(version, server) {
3426
let crate = server.schema.crates.find(version.crate);
3527
crate.update({ versions: crate.versions.concat(parseInt(version.id, 10)) });

mirage/fixtures/crates.js

Lines changed: 0 additions & 115 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,6 @@ export default [{
1212
"network",
1313
],
1414
"license": "MIT",
15-
"links": {
16-
"owner_user": "/api/v1/crates/nanomsg/owner_user",
17-
"owner_team": "/api/v1/crates/nanomsg/owner_team",
18-
"reverse_dependencies": "/api/v1/crates/nanomsg/reverse_dependencies",
19-
"version_downloads": "/api/v1/crates/nanomsg/downloads",
20-
"versions": "/api/v1/crates/nanomsg/versions",
21-
},
2215
"max_version": "0.7.0-alpha",
2316
"name": "nanomsg",
2417
"repository": "https://github.com/thehydroimpulse/nanomsg.rs",
@@ -60,12 +53,6 @@ export default [{
6053
"id": "rust_mixin",
6154
"keywords": ["rust", "plugin", "code-generation"],
6255
"license": "MIT/Apache-2.0",
63-
"links": {
64-
"owners": "/api/v1/crates/rust_mixin/owners",
65-
"reverse_dependencies": "/api/v1/crates/rust_mixin/reverse_dependencies",
66-
"version_downloads": "/api/v1/crates/rust_mixin/downloads",
67-
"versions": "/api/v1/crates/rust_mixin/versions"
68-
},
6956
"max_version": "0.0.1",
7057
"name": "rust_mixin",
7158
"repository": "https://github.com/huonw/external_mixin",
@@ -128,12 +115,6 @@ export default [{
128115
"id": "external_mixin",
129116
"keywords": ["python", "ruby", "shell", "plugin", "code-generation"],
130117
"license": "MIT/Apache-2.0",
131-
"links": {
132-
"owners": "/api/v1/crates/external_mixin/owners",
133-
"reverse_dependencies": "/api/v1/crates/external_mixin/reverse_dependencies",
134-
"version_downloads": "/api/v1/crates/external_mixin/downloads",
135-
"versions": "/api/v1/crates/external_mixin/versions"
136-
},
137118
"max_version": "0.0.1",
138119
"name": "external_mixin",
139120
"repository": "https://github.com/huonw/external_mixin",
@@ -148,12 +129,6 @@ export default [{
148129
"id": "external_mixin_umbrella",
149130
"keywords": ["plugin", "code-generation"],
150131
"license": "MIT/Apache-2.0",
151-
"links": {
152-
"owners": "/api/v1/crates/external_mixin_umbrella/owners",
153-
"reverse_dependencies": "/api/v1/crates/external_mixin_umbrella/reverse_dependencies",
154-
"version_downloads": "/api/v1/crates/external_mixin_umbrella/downloads",
155-
"versions": "/api/v1/crates/external_mixin_umbrella/versions"
156-
},
157132
"max_version": "0.0.2",
158133
"name": "external_mixin_umbrella",
159134
"repository": "https://github.com/huonw/external_mixin",
@@ -168,12 +143,6 @@ export default [{
168143
"id": "Inflector",
169144
"keywords": ["string", "case", "camel", "snake", "inflection"],
170145
"license": "BSD-2-Clause",
171-
"links": {
172-
"owners": "/api/v1/crates/Inflector/owners",
173-
"reverse_dependencies": "/api/v1/crates/Inflector/reverse_dependencies",
174-
"version_downloads": "/api/v1/crates/Inflector/downloads",
175-
"versions": "/api/v1/crates/Inflector/versions"
176-
},
177146
"max_version": "0.1.6",
178147
"name": "Inflector",
179148
"repository": "https://github.com/whatisinternet/inflector",
@@ -188,12 +157,6 @@ export default [{
188157
"id": "rs-es",
189158
"keywords": ["elasticsearch", "elastic"],
190159
"license": "Apache-2.0",
191-
"links": {
192-
"owners": "/api/v1/crates/rs-es/owners",
193-
"reverse_dependencies": "/api/v1/crates/rs-es/reverse_dependencies",
194-
"version_downloads": "/api/v1/crates/rs-es/downloads",
195-
"versions": "/api/v1/crates/rs-es/versions"
196-
},
197160
"max_version": "0.1.17",
198161
"name": "rs-es",
199162
"repository": "https://github.com/benashford/rs-es",
@@ -208,12 +171,6 @@ export default [{
208171
"id": "rust-crypto",
209172
"keywords": ["Crypto", "MD5", "Sha1", "Sha2", "AES"],
210173
"license": "MIT/Apache-2.0",
211-
"links": {
212-
"owners": "/api/v1/crates/rust-crypto/owners",
213-
"reverse_dependencies": "/api/v1/crates/rust-crypto/reverse_dependencies",
214-
"version_downloads": "/api/v1/crates/rust-crypto/downloads",
215-
"versions": "/api/v1/crates/rust-crypto/versions"
216-
},
217174
"max_version": "0.2.34",
218175
"name": "rust-crypto",
219176
"repository": "https://github.com/DaGenix/rust-crypto/",
@@ -228,12 +185,6 @@ export default [{
228185
"id": "rust-htslib",
229186
"keywords": ["htslib", "bam", "bioinformatics", "pileup", "sequencing"],
230187
"license": "MIT",
231-
"links": {
232-
"owners": "/api/v1/crates/rust-htslib/owners",
233-
"reverse_dependencies": "/api/v1/crates/rust-htslib/reverse_dependencies",
234-
"version_downloads": "/api/v1/crates/rust-htslib/downloads",
235-
"versions": "/api/v1/crates/rust-htslib/versions"
236-
},
237188
"max_version": "0.5.2",
238189
"name": "rust-htslib",
239190
"repository": "https://github.com/rust-bio/rust-htslib.git",
@@ -248,12 +199,6 @@ export default [{
248199
"id": "kinetic-rust",
249200
"keywords": ["Protocol", "Kinetic", "Storage"],
250201
"license": "MIT",
251-
"links": {
252-
"owners": "/api/v1/crates/kinetic-rust/owners",
253-
"reverse_dependencies": "/api/v1/crates/kinetic-rust/reverse_dependencies",
254-
"version_downloads": "/api/v1/crates/kinetic-rust/downloads",
255-
"versions": "/api/v1/crates/kinetic-rust/versions"
256-
},
257202
"max_version": "0.0.16",
258203
"name": "kinetic-rust",
259204
"repository": "https://github.com/icorderi/kinetic-rust/",
@@ -268,12 +213,6 @@ export default [{
268213
"id": "rustless",
269214
"keywords": ["api", "web", "hyper", "iron", "rest"],
270215
"license": "MIT",
271-
"links": {
272-
"owners": "/api/v1/crates/rustless/owners",
273-
"reverse_dependencies": "/api/v1/crates/rustless/reverse_dependencies",
274-
"version_downloads": "/api/v1/crates/rustless/downloads",
275-
"versions": "/api/v1/crates/rustless/versions"
276-
},
277216
"max_version": "0.8.0",
278217
"name": "rustless",
279218
"repository": "https://crates.io/crates/rustless",
@@ -288,12 +227,6 @@ export default [{
288227
"id": "serde",
289228
"keywords": ["serde", "serialization"],
290229
"license": "MIT/Apache-2.0",
291-
"links": {
292-
"owners": "/api/v1/crates/serde/owners",
293-
"reverse_dependencies": "/api/v1/crates/serde/reverse_dependencies",
294-
"version_downloads": "/api/v1/crates/serde/downloads",
295-
"versions": "/api/v1/crates/serde/versions"
296-
},
297230
"max_version": "0.6.1",
298231
"name": "serde",
299232
"repository": "https://github.com/serde-rs/serde",
@@ -308,12 +241,6 @@ export default [{
308241
"id": "rusted_cypher",
309242
"keywords": ["neo4j", "database", "query", "cypher", "graph"],
310243
"license": "MIT",
311-
"links": {
312-
"owners": "/api/v1/crates/rusted_cypher/owners",
313-
"reverse_dependencies": "/api/v1/crates/rusted_cypher/reverse_dependencies",
314-
"version_downloads": "/api/v1/crates/rusted_cypher/downloads",
315-
"versions": "/api/v1/crates/rusted_cypher/versions"
316-
},
317244
"max_version": "0.7.1",
318245
"name": "rusted_cypher",
319246
"repository": "https://github.com/livioribeiro/rusted-cypher",
@@ -328,12 +255,6 @@ export default [{
328255
"id": "zlib",
329256
"keywords": [],
330257
"license": "MIT",
331-
"links": {
332-
"owners": "/api/v1/crates/zlib/owners",
333-
"reverse_dependencies": "/api/v1/crates/zlib/reverse_dependencies",
334-
"version_downloads": "/api/v1/crates/zlib/downloads",
335-
"versions": "/api/v1/crates/zlib/versions"
336-
},
337258
"max_version": "0.0.1",
338259
"name": "zlib",
339260
"repository": null,
@@ -348,12 +269,6 @@ export default [{
348269
"id": "rustful",
349270
"keywords": ["web", "rest", "framework", "http", "routing"],
350271
"license": "MIT",
351-
"links": {
352-
"owners": "/api/v1/crates/rustful/owners",
353-
"reverse_dependencies": "/api/v1/crates/rustful/reverse_dependencies",
354-
"version_downloads": "/api/v1/crates/rustful/downloads",
355-
"versions": "/api/v1/crates/rustful/versions"
356-
},
357272
"max_version": "0.5.0",
358273
"name": "rustful",
359274
"repository": "https://github.com/Ogeon/rustful",
@@ -368,12 +283,6 @@ export default [{
368283
"id": "postgres",
369284
"keywords": ["database", "sql"],
370285
"license": "MIT",
371-
"links": {
372-
"owners": "/api/v1/crates/postgres/owners",
373-
"reverse_dependencies": "/api/v1/crates/postgres/reverse_dependencies",
374-
"version_downloads": "/api/v1/crates/postgres/downloads",
375-
"versions": "/api/v1/crates/postgres/versions"
376-
},
377286
"max_version": "0.10.1",
378287
"name": "postgres",
379288
"repository": "https://github.com/sfackler/rust-postgres",
@@ -388,12 +297,6 @@ export default [{
388297
"id": "quickcheck",
389298
"keywords": ["testing", "quickcheck", "property", "shrinking", "fuzz"],
390299
"license": "Unlicense/MIT",
391-
"links": {
392-
"owners": "/api/v1/crates/quickcheck/owners",
393-
"reverse_dependencies": "/api/v1/crates/quickcheck/reverse_dependencies",
394-
"version_downloads": "/api/v1/crates/quickcheck/downloads",
395-
"versions": "/api/v1/crates/quickcheck/versions"
396-
},
397300
"max_version": "0.2.24",
398301
"name": "quickcheck",
399302
"repository": "https://github.com/BurntSushi/quickcheck",
@@ -408,12 +311,6 @@ export default [{
408311
"id": "quickcheck_macros",
409312
"keywords": ["testing", "quickcheck", "property", "shrinking", "fuzz"],
410313
"license": "Unlicense/MIT",
411-
"links": {
412-
"owners": "/api/v1/crates/quickcheck_macros/owners",
413-
"reverse_dependencies": "/api/v1/crates/quickcheck_macros/reverse_dependencies",
414-
"version_downloads": "/api/v1/crates/quickcheck_macros/downloads",
415-
"versions": "/api/v1/crates/quickcheck_macros/versions"
416-
},
417314
"max_version": "0.2.24",
418315
"name": "quickcheck_macros",
419316
"repository": "https://github.com/BurntSushi/quickcheck",
@@ -428,12 +325,6 @@ export default [{
428325
"id": "nc_rustlex",
429326
"keywords": ["lexer", "lexical", "analyser", "generator"],
430327
"license": "MIT",
431-
"links": {
432-
"owners": "/api/v1/crates/nc_rustlex/owners",
433-
"reverse_dependencies": "/api/v1/crates/nc_rustlex/reverse_dependencies",
434-
"version_downloads": "/api/v1/crates/nc_rustlex/downloads",
435-
"versions": "/api/v1/crates/nc_rustlex/versions"
436-
},
437328
"max_version": "0.3.1",
438329
"name": "nc_rustlex",
439330
"repository": "https://github.com/nicolas-cherel/rustlex",
@@ -448,12 +339,6 @@ export default [{
448339
"id": "nom",
449340
"keywords": ["parser", "parser-combinators", "parsing", "streaming", "bit"],
450341
"license": "MIT",
451-
"links": {
452-
"owners": "/api/v1/crates/nom/owners",
453-
"reverse_dependencies": "/api/v1/crates/nom/reverse_dependencies",
454-
"version_downloads": "/api/v1/crates/nom/downloads",
455-
"versions": "/api/v1/crates/nom/versions"
456-
},
457342
"max_version": "1.0.1",
458343
"name": "nom",
459344
"repository": "https://github.com/Geal/nom",

0 commit comments

Comments
 (0)