Skip to content

Commit c6719b7

Browse files
committed
cargo fmt
1 parent 5debe10 commit c6719b7

File tree

3 files changed

+53
-22
lines changed

3 files changed

+53
-22
lines changed

src/krate.rs

Lines changed: 40 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ use {Model, User, Keyword, Version, Category, Badge, Replica};
4343
#[derive(Insertable, Queryable, Identifiable, Associations, AsChangeset)]
4444
#[belongs_to(Crate)]
4545
#[primary_key(crate_id, date)]
46-
#[table_name="crate_downloads"]
46+
#[table_name = "crate_downloads"]
4747
pub struct CrateDownload {
4848
pub crate_id: i32,
4949
pub downloads: i32,
@@ -499,7 +499,15 @@ impl Crate {
499499
exact_match: bool,
500500
recent_downloads: Option<i64>,
501501
) -> EncodableCrate {
502-
self.encodable(max_version, None, None, None, badges, exact_match, recent_downloads)
502+
self.encodable(
503+
max_version,
504+
None,
505+
None,
506+
None,
507+
badges,
508+
exact_match,
509+
recent_downloads,
510+
)
503511
}
504512

505513
pub fn encodable(
@@ -805,20 +813,26 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
805813
let conn = req.db_conn()?;
806814
let (offset, limit) = req.pagination(10, 100)?;
807815
let params = req.query();
808-
let sort = params.get("sort").map(|s| &**s).unwrap_or("recent-downloads");
816+
let sort = params.get("sort").map(|s| &**s).unwrap_or(
817+
"recent-downloads",
818+
);
809819

810820
let recent_downloads = sql::<Nullable<BigInt>>("SUM(crate_downloads.downloads)");
811821

812822
let mut query = crates::table
813823
.join(
814824
crate_downloads::table,
815825
LeftOuter,
816-
crates::id
817-
.eq(crate_downloads::crate_id)
818-
.and(crate_downloads::date.gt(date(now - 90.days())))
819-
)
826+
crates::id.eq(crate_downloads::crate_id).and(
827+
crate_downloads::date.gt(date(now - 90.days())),
828+
),
829+
)
820830
.group_by(crates::id)
821-
.select((ALL_COLUMNS, AsExpression::<Bool>::as_expression(false), recent_downloads.clone()))
831+
.select((
832+
ALL_COLUMNS,
833+
AsExpression::<Bool>::as_expression(false),
834+
recent_downloads.clone(),
835+
))
822836
.into_boxed();
823837

824838
if sort == "downloads" {
@@ -838,7 +852,11 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
838852
),
839853
));
840854

841-
query = query.select((ALL_COLUMNS, crates::name.eq(q_string), recent_downloads.clone()));
855+
query = query.select((
856+
ALL_COLUMNS,
857+
crates::name.eq(q_string),
858+
recent_downloads.clone(),
859+
));
842860
let perfect_match = crates::name.eq(q_string).desc();
843861
if sort == "downloads" {
844862
query = query.order((perfect_match, crates::downloads.desc()));
@@ -910,15 +928,21 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
910928
));
911929
}
912930

913-
let data = query.paginate(limit, offset).load::<((Crate, bool, Option<i64>), i64)>(
914-
&*conn,
915-
)?;
931+
let data = query
932+
.paginate(limit, offset)
933+
.load::<((Crate, bool, Option<i64>), i64)>(&*conn)?;
916934
let total = data.first().map(|&(_, t)| t).unwrap_or(0);
917935
let crates = data.iter()
918936
.map(|&((ref c, _, _), _)| c.clone())
919937
.collect::<Vec<_>>();
920-
let perfect_matches = data.clone().into_iter().map(|((_, b, _), _)| b).collect::<Vec<_>>();
921-
let recent_downloads = data.clone().into_iter().map(|((_, _, s), _)| s.unwrap_or(0)).collect::<Vec<_>>();
938+
let perfect_matches = data.clone()
939+
.into_iter()
940+
.map(|((_, b, _), _)| b)
941+
.collect::<Vec<_>>();
942+
let recent_downloads = data.clone()
943+
.into_iter()
944+
.map(|((_, _, s), _)| s.unwrap_or(0))
945+
.collect::<Vec<_>>();
922946

923947
let versions = Version::belonging_to(&crates)
924948
.load::<Version>(&*conn)?
@@ -930,7 +954,8 @@ pub fn index(req: &mut Request) -> CargoResult<Response> {
930954
.zip(crates)
931955
.zip(perfect_matches)
932956
.zip(recent_downloads)
933-
.map(|(((max_version, krate), perfect_match), recent_downloads)| {
957+
.map(|(((max_version, krate), perfect_match),
958+
recent_downloads)| {
934959
// FIXME: If we add crate_id to the Badge enum we can eliminate
935960
// this N+1
936961
let badges = badges::table

src/tests/all.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,9 @@ impl<'a> CrateBuilder<'a> {
390390
date: old_date,
391391
};
392392

393-
insert(&crate_download).into(crate_downloads::table).execute(connection)?;
393+
insert(&crate_download)
394+
.into(crate_downloads::table)
395+
.execute(connection)?;
394396
krate.downloads = downloads;
395397
update(&krate).set(&krate).execute(connection)?;
396398
}
@@ -402,7 +404,9 @@ impl<'a> CrateBuilder<'a> {
402404
date: now.naive_utc().date(),
403405
};
404406

405-
insert(&crate_download).into(crate_downloads::table).execute(connection)?;
407+
insert(&crate_download)
408+
.into(crate_downloads::table)
409+
.execute(connection)?;
406410
}
407411

408412
if self.versions.is_empty() {

src/tests/krate.rs

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -366,7 +366,9 @@ fn exact_match_on_queries_with_sort() {
366366
assert_eq!(json.crates[3].name, "foo_sort");
367367

368368
// Sort by recent-downloads
369-
let mut response = ok_resp!(middle.call(req.with_query("q=bar_sort&sort=recent-downloads")));
369+
let mut response = ok_resp!(middle.call(
370+
req.with_query("q=bar_sort&sort=recent-downloads"),
371+
));
370372
let json: CrateList = ::json(&mut response);
371373
assert_eq!(json.meta.total, 3);
372374
assert_eq!(json.crates[0].name, "bar_sort");
@@ -1964,7 +1966,7 @@ fn test_recent_download_count() {
19641966

19651967
let mut req = ::req(app, Method::Get, "/api/v1/crates");
19661968
let mut response = ok_resp!(middle.call(req.with_query("sort=recent-downloads")));
1967-
let json:CrateList = ::json(&mut response);
1969+
let json: CrateList = ::json(&mut response);
19681970

19691971
assert_eq!(json.meta.total, 2);
19701972

@@ -2000,7 +2002,7 @@ fn test_zero_downloads() {
20002002

20012003
let mut req = ::req(app, Method::Get, "/api/v1/crates");
20022004
let mut response = ok_resp!(middle.call(req.with_query("sort=recent-downloads")));
2003-
let json:CrateList = ::json(&mut response);
2005+
let json: CrateList = ::json(&mut response);
20042006

20052007
assert_eq!(json.meta.total, 1);
20062008

@@ -2043,7 +2045,7 @@ fn test_default_sort_recent() {
20432045
// by default
20442046
let mut req = ::req(app.clone(), Method::Get, "/api/v1/crates");
20452047
let mut response = ok_resp!(middle.call(req.with_query("keyword=dog")));
2046-
let json:CrateList = ::json(&mut response);
2048+
let json: CrateList = ::json(&mut response);
20472049

20482050
assert_eq!(json.meta.total, 2);
20492051

@@ -2068,7 +2070,7 @@ fn test_default_sort_recent() {
20682070
// test that index for categories is sorted by recent_downloads
20692071
// by default
20702072
let mut response = ok_resp!(middle.call(req.with_query("category=animal")));
2071-
let json:CrateList = ::json(&mut response);
2073+
let json: CrateList = ::json(&mut response);
20722074

20732075
assert_eq!(json.meta.total, 2);
20742076

0 commit comments

Comments
 (0)