migrate to using tracing instead of log

Author: syphar

Cargo.lock

@@ -20,10 +20,13 @@ consistency_check = ["crates-index", "rayon"]
 
 [dependencies]
 sentry = "0.27.0"
-sentry-log = "0.27.0"
 sentry-panic = "0.27.0"
+sentry-tracing = "0.27.0"
 sentry-anyhow = { version = "0.27.0", features = ["backtrace"] }
 log = "0.4"
+tracing = "0.1.37"
+tracing-subscriber = { version = "0.3.16", default-features = false, features = ["ansi", "fmt", "env-filter"] }
+tracing-log = "0.1.3"
 regex = "1"
 structopt = "0.3"
 crates-index = { version = "0.18.5", optional = true }
@@ -32,7 +35,6 @@ crates-index-diff = "10.0.0"
 reqwest = { version = "0.11", features = ["blocking", "json"] } # TODO: Remove blocking when async is ready
 semver = { version = "1.0.4", features = ["serde"] }
 slug = "0.1.1"
-env_logger = "0.9.0"
 r2d2 = "0.8"
 r2d2_postgres = "0.18"
 # iron needs url@1, but it reexports it as iron::url, so we can start using

Cargo.toml

@@ -1,6 +1,7 @@
 use std::env;
 use std::fmt::Write;
 use std::path::PathBuf;
+use std::str::FromStr;
 use std::sync::Arc;
 
 use anyhow::{anyhow, Context as _, Error, Result};
@@ -14,14 +15,28 @@ use docs_rs::{
     BuildQueue, Config, Context, Index, Metrics, PackageKind, RustwideBuilder, Server, Storage,
 };
 use once_cell::sync::OnceCell;
-use sentry_log::SentryLogger;
 use structopt::StructOpt;
 use strum::VariantNames;
 use tokio::runtime::Runtime;
+use tracing_log::LogTracer;
+use tracing_subscriber::{filter::Directive, prelude::*, EnvFilter};
 
 fn main() {
+    // set the global log::logger for backwards compatibility
+    // through rustwide.
+    rustwide::logging::init_with(LogTracer::new());
+
+    let tracing_registry = tracing_subscriber::registry()
+        .with(tracing_subscriber::fmt::layer())
+        .with(
+            EnvFilter::builder()
+                .with_default_directive(Directive::from_str("docs_rs=info").unwrap())
+                .with_env_var("DOCSRS_LOG")
+                .from_env_lossy(),
+        );
+
     let _sentry_guard = if let Ok(sentry_dsn) = env::var("SENTRY_DSN") {
-        rustwide::logging::init_with(SentryLogger::with_dest(logger_init()));
+        tracing_registry.with(sentry_tracing::layer()).init();
         Some(sentry::init((
             sentry_dsn,
             sentry::ClientOptions {
@@ -32,7 +47,7 @@ fn main() {
             .add_integration(sentry_panic::PanicIntegration::default()),
         )))
     } else {
-        rustwide::logging::init_with(logger_init());
+        tracing_registry.init();
         None
     };
 
@@ -56,24 +71,6 @@ fn main() {
     }
 }
 
-fn logger_init() -> env_logger::Logger {
-    use std::io::Write;
-
-    let env = env_logger::Env::default().filter_or("DOCSRS_LOG", "docs_rs=info");
-    env_logger::Builder::from_env(env)
-        .format(|buf, record| {
-            writeln!(
-                buf,
-                "{} [{}] {}: {}",
-                time::now().strftime("%Y/%m/%d %H:%M:%S").unwrap(),
-                record.level(),
-                record.target(),
-                record.args()
-            )
-        })
-        .build()
-}
-
 #[derive(Debug, Clone, Copy, PartialEq, Eq, strum::EnumString, strum::EnumVariantNames)]
 #[strum(serialize_all = "snake_case")]
 enum Toggle {

src/bin/cratesfyi.rs

@@ -8,7 +8,7 @@ use crate::{Config, Index, Metrics, RustwideBuilder};
 use anyhow::Context;
 
 use crates_index_diff::Change;
-use log::{debug, info};
+use tracing::{debug, info};
 
 use git2::Oid;
 use std::sync::Arc;
@@ -239,7 +239,7 @@ fn retry<T>(mut f: impl FnMut() -> Result<T>, max_attempts: u32) -> Result<T> {
                     return Err(err);
                 } else {
                     let sleep_for = 2u32.pow(attempt);
-                    log::warn!(
+                    tracing::warn!(
                         "got error on attempt {}, will try again after {}s:\n{:?}",
                         attempt,
                         sleep_for,

src/build_queue.rs

@@ -205,7 +205,7 @@ where
             .map(Some)
             .with_context(|| format!("failed to parse configuration variable {}", var))?),
         Err(VarError::NotPresent) => {
-            log::trace!("optional configuration variable {} is not set", var);
+            tracing::trace!("optional configuration variable {} is not set", var);
             Ok(None)
         }
         Err(VarError::NotUnicode(_)) => Err(anyhow!("configuration variable {} is not UTF-8", var)),

src/config.rs

@@ -8,7 +8,6 @@ use crate::{
     web::crate_details::CrateDetails,
 };
 use anyhow::{anyhow, Context};
-use log::{debug, info};
 use postgres::Client;
 use serde_json::Value;
 use slug::slugify;
@@ -18,6 +17,7 @@ use std::{
     io::{BufRead, BufReader},
     path::Path,
 };
+use tracing::{debug, info};
 
 /// Adds a package into database.
 ///