oops: semantics of repeat expr in array is the same

Author: tesuji

clippy_lints/src/reference.rs

@@ -48,8 +48,8 @@ impl EarlyLintPass for DerefAddrOf {
     fn check_expr(&mut self, cx: &EarlyContext<'_>, e: &Expr) {
         if let ExprKind::Unary(UnOp::Deref, ref deref_target) = e.kind
             && let ExprKind::AddrOf(_, ref mutability, ref addrof_target) = without_parens(deref_target).kind
-            // NOTE(tesuji): semantics diffences with/out `*&` for array
-            && !matches!(addrof_target.kind, ExprKind::Array(_) | ExprKind::Repeat(..))
+            // NOTE(tesuji): semantics diffences with/out `*&` for array literal `[x, y, ..]`
+            && !matches!(addrof_target.kind, ExprKind::Array(_))
             && deref_target.span.eq_ctxt(e.span)
             && !addrof_target.span.from_expansion()
         {

tests/ui/deref_addrof.fixed

@@ -44,8 +44,8 @@ fn main() {
 
     let _ = unsafe { *core::ptr::addr_of!(a) };
 
+    let _repeat = [0; 64];
     // do NOT lint for array as sematic differences with/out `*&`.
-    let _repeat = *&[0; 64];
     let _arr = *&[0, 1, 2, 3, 4];
 }
 

tests/ui/deref_addrof.rs

@@ -44,8 +44,8 @@ fn main() {
 
     let _ = unsafe { *core::ptr::addr_of!(a) };
 
-    // do NOT lint for array as sematic differences with/out `*&`.
     let _repeat = *&[0; 64];
+    // do NOT lint for array as sematic differences with/out `*&`.
     let _arr = *&[0, 1, 2, 3, 4];
 }
 

tests/ui/deref_addrof.stderr

@@ -49,6 +49,12 @@ error: immediately dereferencing a reference
 LL |     let b = **&aref;
    |              ^^^^^^ help: try: `aref`
 
+error: immediately dereferencing a reference
+  --> tests/ui/deref_addrof.rs:47:19
+   |
+LL |     let _repeat = *&[0; 64];
+   |                   ^^^^^^^^^ help: try: `[0; 64]`
+
 error: immediately dereferencing a reference
   --> tests/ui/deref_addrof.rs:57:17
    |
@@ -65,5 +71,5 @@ LL |         inline!(*&mut $(@expr self))
    |
    = note: this error originates in the macro `__inline_mac_impl` (in Nightly builds, run with -Z macro-backtrace for more info)
 
-error: aborting due to 10 previous errors
+error: aborting due to 11 previous errors