Skip to content

Off-by-one suggestion message line number when includes trailing newline #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ehuss opened this issue Oct 6, 2024 · 0 comments
Open
Labels
A-messages Area: Build messages

Comments

@ehuss
Copy link

ehuss commented Oct 6, 2024

When a build message includes a suggestion, and the suggestion includes the newline, the suggestion phantom is attached to the following line. Although this makes sense from the perspective that the end of the phantom really is on the next line, it looks weird.

Image

In the above, the suggestion to remove the line also includes the newline.

Ideally it would be nice to detect this special case of the last line of the phantom is empty, and move the phantom up by one line.

@ehuss ehuss added the A-messages Area: Build messages label Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-messages Area: Build messages
Projects
None yet
Development

No branches or pull requests

1 participant