From 8d6fb44c9950dbb89a4470e2050f8692b87debb3 Mon Sep 17 00:00:00 2001 From: Corey Richardson Date: Fri, 27 Mar 2015 17:29:07 -0400 Subject: [PATCH] rustdoc: show negative impls properly in the implementors page This isn't really possible to test in an automatic way, since the only traits you can negative impl are `Send` and `Sync`, and the implementors page for those only exists in libstd. Closes #21310 --- src/librustdoc/html/render.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/librustdoc/html/render.rs b/src/librustdoc/html/render.rs index d57739c400249..8747a2529545d 100644 --- a/src/librustdoc/html/render.rs +++ b/src/librustdoc/html/render.rs @@ -125,6 +125,7 @@ pub struct Implementor { pub trait_: clean::Type, pub for_: clean::Type, pub stability: Option, + pub polarity: Option, } /// Metadata about implementations for a type. @@ -635,9 +636,11 @@ fn write_shared(cx: &Context, // going on). If they're in different crates then the crate defining // the trait will be interested in our implementation. if imp.def_id.krate == did.krate { continue } - try!(write!(&mut f, r#""{}impl{} {} for {}","#, + try!(write!(&mut f, r#""{}impl{} {}{} for {}","#, ConciseStability(&imp.stability), - imp.generics, imp.trait_, imp.for_)); + imp.generics, + if imp.polarity == Some(clean::ImplPolarity::Negative) { "!" } else { "" }, + imp.trait_, imp.for_)); } try!(writeln!(&mut f, r"];")); try!(writeln!(&mut f, "{}", r" @@ -884,6 +887,7 @@ impl DocFolder for Cache { trait_: i.trait_.as_ref().unwrap().clone(), for_: i.for_.clone(), stability: item.stability.clone(), + polarity: i.polarity.clone(), }); } Some(..) | None => {}