From c608270c3bab5e0e643837e510bc504798a267da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Ber=C3=A1nek?= Date: Tue, 4 Mar 2025 11:03:07 +0100 Subject: [PATCH 1/2] Produce an error when rustc benchmark produces no timing data --- collector/src/compile/execute/rustc.rs | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/collector/src/compile/execute/rustc.rs b/collector/src/compile/execute/rustc.rs index f5b2823b2..bfbf963e7 100644 --- a/collector/src/compile/execute/rustc.rs +++ b/collector/src/compile/execute/rustc.rs @@ -144,6 +144,14 @@ async fn record( } } + // Sanity check + if timing_data.is_empty() { + return Err(anyhow::anyhow!( + "rustc benchmark failed to produce timing data\nSTDOUT:\n{}\n\nSTDERR:{timings}\n", + String::from_utf8_lossy(&output.stdout) + )); + } + let version = get_rustc_perf_commit(); let collection = conn.collection_id(&version).await; From 522533c7b0d103c3f460d0b7464d92f85e355d79 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Jakub=20Ber=C3=A1nek?= Date: Tue, 4 Mar 2025 11:03:37 +0100 Subject: [PATCH 2/2] Actually build the compiler in bootstrap benchmark This was broken after a recent bootstrap change. --- collector/src/compile/execute/rustc.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/collector/src/compile/execute/rustc.rs b/collector/src/compile/execute/rustc.rs index bfbf963e7..fd542482f 100644 --- a/collector/src/compile/execute/rustc.rs +++ b/collector/src/compile/execute/rustc.rs @@ -117,7 +117,7 @@ async fn record( .env("BOOTSTRAP_SKIP_TARGET_SANITY", "1") .arg("build") .arg("--stage") - .arg("0") + .arg("1") // We want bootstrap and the Cargos it spawns to have no parallelism -- // if multiple rustcs are competing for jobserver tokens, we introduce // quite a bit of variance.