From 47ac5f02d68f9580bda25f0552b38892eb347caa Mon Sep 17 00:00:00 2001 From: Tobias Schlatter Date: Wed, 20 Jan 2021 13:20:47 +0100 Subject: [PATCH] Fix #105: Re-enable largeMessageTest The upstream issue [1] has been fixed in Chrome 89, which has just hit the GitHub Actions virtual environment [2]. [1]: https://bugs.chromium.org/p/chromedriver/issues/detail?id=3672 [2]: https://github.com/actions/virtual-environments/releases/tag/ubuntu20%2F20210309.1 --- .../jsenv/selenium/SeleniumJSEnvSuite.scala | 23 +------------------ 1 file changed, 1 insertion(+), 22 deletions(-) diff --git a/seleniumJSEnv/src/test/scala/org/scalajs/jsenv/selenium/SeleniumJSEnvSuite.scala b/seleniumJSEnv/src/test/scala/org/scalajs/jsenv/selenium/SeleniumJSEnvSuite.scala index 0c8e2bd..ec321fd 100644 --- a/seleniumJSEnv/src/test/scala/org/scalajs/jsenv/selenium/SeleniumJSEnvSuite.scala +++ b/seleniumJSEnv/src/test/scala/org/scalajs/jsenv/selenium/SeleniumJSEnvSuite.scala @@ -10,28 +10,7 @@ import org.junit.runners.Suite import org.junit.runner.manipulation.Filter import org.junit.runner.Description -@RunWith(classOf[SeleniumJSSuiteRunner]) +@RunWith(classOf[JSEnvSuiteRunner]) class SeleniumJSSuite extends JSEnvSuite( JSEnvSuiteConfig(new SeleniumJSEnv(TestCapabilities.fromEnv)) ) - -class SeleniumJSSuiteRunner private ( - root: Class[_], base: JSEnvSuiteRunner) - extends Suite(root, Arrays.asList[Runner](base)) { - - /** Constructor for reflective instantiation via `@RunWith`. */ - def this(suite: Class[_ <: SeleniumJSSuite]) = - this(suite, new JSEnvSuiteRunner(suite)) - - // Ignore `largeMessageTest` for chrome. - if (TestCapabilities.nameFromEnv == "chrome") { - base.filter(new Filter { - def describe(): String = "Ignore largeMessageTest" - - def shouldRun(description: Description): Boolean = { - description.getMethodName == null || - !description.getMethodName.startsWith("largeMessageTest") - } - }) - } -}